Bug 2001211: Resource usage measurement data display the concatenati… #11805

tvu20 · 2022-07-08T17:01:27Z

…on of English and translation sentence fragments on utilization section when moving the mouse over each resource usage chart in Developer->Project

Addresses translation misses and concatenation between English and Chinese on the utilization section when moving the mouse over chartsin Developer->Project

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2001211

openshift-ci · 2022-07-12T19:35:57Z

@tvu20: This pull request references Bugzilla bug 2001211, which is invalid:

expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2001211: Resource usage measurement data display the concatenati…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tvu20 · 2022-07-12T19:36:23Z

/bugzilla refresh

openshift-ci · 2022-07-12T19:36:52Z

@tvu20: This pull request references Bugzilla bug 2001211, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tvu20 · 2022-07-13T13:09:07Z

/retest

tvu20 · 2022-07-13T16:43:10Z

/retest

tvu20 · 2022-07-14T13:20:26Z

/retest

tvu20 · 2022-07-14T20:44:06Z

/retest

tvu20 · 2022-07-18T17:27:15Z

/retest

tvu20 · 2022-07-18T18:06:03Z

/retest

tvu20 · 2022-07-18T19:35:04Z

/retest

jhadvig

@tvu20 thanks for the PR ! Adding couple of comments :)

frontend/packages/console-shared/src/components/dashboard/utilization-card/UtilizationItem.tsx

…on of English and translation sentence fragments on utilization section when moving the mouse over each resource usage chart in Developer->Project Addresses translation misses and concatenation between English and Chinese on the utilization section when moving the mouse over chartsin Developer->Project Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2001211

jhadvig

/lgtm
/approve

openshift-ci · 2022-07-29T15:30:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, tvu20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2022-07-29T20:54:26Z

/retest-required

Remaining retests: 2 against base HEAD 4b44e42 and 8 for PR HEAD 4d5cd99 in total

openshift-ci-robot · 2022-07-29T22:46:24Z

/retest-required

Remaining retests: 1 against base HEAD 4b44e42 and 7 for PR HEAD 4d5cd99 in total

openshift-ci-robot · 2022-07-30T01:46:16Z

/retest-required

Remaining retests: 0 against base HEAD 4b44e42 and 6 for PR HEAD 4d5cd99 in total

jhadvig · 2022-08-01T07:25:34Z

Failed Specs:
1) CRD extensions ConsoleNotification CRD : deletes the ConsoleNotification instance
   NoSuchElementError: No element found using locator: By(css selector, [data-test-action="View instances"]:not(.pf-m-disabled))
       at /go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:814:27
       at ManagedPromise.invokeCallback_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:1376:14
       at TaskQueue.execute_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:3084:14
       at TaskQueue.executeNext_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:3067:27
       at /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:2927:27
       at /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:668:7
       at runMicrotasks <anonymous>:null:null
       at processTicksAndRejections internal/process/task_queues.js:93:5
   Error
       at ElementArrayFinder.applyAction_ /go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:459:27
       at ElementArrayFinder.<computed> [as click] /go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:91:29
       at ElementFinder.<computed> [as click] /go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:831:22
       at /go/src/github.com/openshift/console/frontend/integration-tests/views/crud.view.ts:82:57
       at ManagedPromise.invokeCallback_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:1376:14
       at TaskQueue.execute_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:3084:14
       at TaskQueue.executeNext_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:3067:27
       at /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:2927:27
       at /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:668:7
       at runMicrotasks <anonymous>:null:null
       at processTicksAndRejections internal/process/task_queues.js:93:5
   
   From: Task: Run it"deletes the ConsoleNotification instance" in control flow
       at UserContext.<anonymous> /go/src/github.com/openshift/console/frontend/node_modules/jasminewd2/index.js:94:19
       at processImmediate internal/timers.js:461:21

/retest

openshift-ci-robot · 2022-08-01T14:56:33Z

/retest-required

Remaining retests: 2 against base HEAD 55b6709 and 5 for PR HEAD 4d5cd99 in total

openshift-ci · 2022-08-01T18:42:20Z

@tvu20: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-08-02T05:17:47Z

@tvu20: All pull requests linked via external trackers have merged:

openshift/console#11805

Bugzilla bug 2001211 has been moved to the MODIFIED state.

In response to this:

Bug 2001211: Resource usage measurement data display the concatenati…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from andybraren and jhadvig July 8, 2022 17:02

openshift-ci bot added component/dashboard Related to dashboard component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 8, 2022

tvu20 changed the title ~~Bug 2001211 - Resource usage measurement data display the concatenati…~~ Bug 2001211: Resource usage measurement data display the concatenati… Jul 12, 2022

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 12, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 12, 2022

openshift-ci bot requested a review from yapei July 12, 2022 19:36

jhadvig reviewed Jul 25, 2022

View reviewed changes

tvu20 force-pushed the Bug2001211 branch from 4f7d931 to 4d5cd99 Compare July 25, 2022 13:56

jhadvig approved these changes Jul 29, 2022

View reviewed changes

openshift-ci bot assigned jhadvig Jul 29, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2022

openshift-merge-robot merged commit 6dbc046 into openshift:master Aug 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2001211: Resource usage measurement data display the concatenati… #11805

Bug 2001211: Resource usage measurement data display the concatenati… #11805

tvu20 commented Jul 8, 2022

openshift-ci bot commented Jul 12, 2022

tvu20 commented Jul 12, 2022

openshift-ci bot commented Jul 12, 2022

tvu20 commented Jul 13, 2022

tvu20 commented Jul 13, 2022

tvu20 commented Jul 14, 2022

tvu20 commented Jul 14, 2022

tvu20 commented Jul 18, 2022

tvu20 commented Jul 18, 2022

tvu20 commented Jul 18, 2022

jhadvig left a comment

jhadvig left a comment

openshift-ci bot commented Jul 29, 2022

openshift-ci-robot commented Jul 29, 2022

openshift-ci-robot commented Jul 29, 2022

openshift-ci-robot commented Jul 30, 2022

jhadvig commented Aug 1, 2022

openshift-ci-robot commented Aug 1, 2022

openshift-ci bot commented Aug 1, 2022

openshift-ci bot commented Aug 2, 2022

Bug 2001211: Resource usage measurement data display the concatenati… #11805

Bug 2001211: Resource usage measurement data display the concatenati… #11805

Conversation

tvu20 commented Jul 8, 2022

openshift-ci bot commented Jul 12, 2022

tvu20 commented Jul 12, 2022

openshift-ci bot commented Jul 12, 2022

tvu20 commented Jul 13, 2022

tvu20 commented Jul 13, 2022

tvu20 commented Jul 14, 2022

tvu20 commented Jul 14, 2022

tvu20 commented Jul 18, 2022

tvu20 commented Jul 18, 2022

tvu20 commented Jul 18, 2022

jhadvig left a comment

Choose a reason for hiding this comment

jhadvig left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jul 29, 2022

openshift-ci-robot commented Jul 29, 2022

openshift-ci-robot commented Jul 29, 2022

openshift-ci-robot commented Jul 30, 2022

jhadvig commented Aug 1, 2022

openshift-ci-robot commented Aug 1, 2022

openshift-ci bot commented Aug 1, 2022

openshift-ci bot commented Aug 2, 2022