Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-3204: Add missing api docs for *Icon and *Status components #11806

Closed
wants to merge 10 commits into from

Conversation

tvu20
Copy link
Contributor

@tvu20 tvu20 commented Jul 8, 2022

Updates to the API docs for dynamic plugin sdk.

@openshift-ci openshift-ci bot added the component/sdk Related to console-plugin-sdk label Jul 8, 2022
* Component for displaying a green check mark circle icon
* @param {string} [className] - (optional) class name for styling
* @param {string} [title] - (optional) icon title
* @param {string} [size] - (optional) icon size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and list the options here 'sm' | 'md' | 'lg' | 'xl' and for any place with the size param

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@tvu20: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Updates to the API docs for dynamic plugin sdk.
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console labels Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tvu20
To complete the pull request process, please assign rhamilto after the PR has been reviewed.
You can assign the PR to them by writing /assign @rhamilto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/topology Related to topology labels Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@tvu20: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 6466cb9 link true /test frontend
ci/prow/backend 6466cb9 link true /test backend
ci/prow/e2e-gcp-console 6466cb9 link true /test e2e-gcp-console
ci/prow/analyze 6466cb9 link true /test analyze
ci/prow/images 6466cb9 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tvu20 tvu20 closed this Jul 8, 2022
@tvu20 tvu20 deleted the CONSOLE-3204 branch July 8, 2022 19:16
@tvu20 tvu20 restored the CONSOLE-3204 branch July 8, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/topology Related to topology needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants