Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CONSOLE-3202: utilize Core SDK extensions #11978

Closed
wants to merge 2 commits into from

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Aug 23, 2022

Alternate approach to #11841 per @vojtechszocs's instruction. Includes changes from #11994.

Known issues:

  • doesn't build (@vojtechszocs investigating)
  • some types have changed (those have a name that includes 2 and are commented // DO NOT COMMIT)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2022
@openshift-ci openshift-ci bot added the component/sdk Related to console-plugin-sdk label Aug 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@TheRealJon
Copy link
Member

TheRealJon commented Aug 23, 2022

Build failure:

UnknownTypeError: Unknown type "function"
    at ChainTypeFormatter.getTypeFormatter (/src/console/frontend/node_modules/ts-json-schema-generator/dist/src/src/src/ChainTypeFormatter.ts:32:15)
    at ChainTypeFormatter.getChildren (/src/console/frontend/node_modules/ts-json-schema-generator/dist/src/src/src/ChainTypeFormatter.ts:22:21)
    at CircularReferenceTypeFormatter.getChildren (/src/console/frontend/node_modules/ts-json-schema-generator/dist/src/src/src/CircularReferenceTypeFormatter.ts:32:50)
    at /src/console/frontend/node_modules/ts-json-schema-generator/dist/src/TypeFormatter/src/src/TypeFormatter/UnionTypeFormatter.ts:71:94
    at Array.reduce (<anonymous>)
    at UnionTypeFormatter.getChildren (/src/console/frontend/node_modules/ts-json-schema-generator/dist/src/TypeFormatter/src/src/TypeFormatter/UnionTypeFormatter.ts:71:18)
    at ChainTypeFormatter.getChildren (/src/console/frontend/node_modules/ts-json-schema-generator/dist/src/src/src/ChainTypeFormatter.ts:22:44)
    at CircularReferenceTypeFormatter.getChildren (/src/console/frontend/node_modules/ts-json-schema-generator/dist/src/src/src/CircularReferenceTypeFormatter.ts:32:50)
    at AliasTypeFormatter.getChildren (/src/console/frontend/node_modules/ts-json-schema-generator/dist/src/TypeFormatter/src/src/TypeFormatter/AliasTypeFormatter.ts:17:40)
    at ChainTypeFormatter.getChildren (/src/console/frontend/node_modules/ts-json-schema-generator/dist/src/src/src/ChainTypeFormatter.ts:22:44) {
  type: FunctionType {}
}

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2022
@openshift-merge-robot
Copy link
Contributor

@rhamilto: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

@rhamilto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console a94e23c link true /test e2e-gcp-console
ci/prow/images a94e23c link true /test images
ci/prow/frontend a94e23c link true /test frontend
ci/prow/analyze a94e23c link true /test analyze
ci/prow/backend a94e23c link true /test backend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhamilto
Copy link
Member Author

This story is being shelved for the time being while the core SDK team works on adding the core SDK to console.

@rhamilto rhamilto closed this Sep 14, 2022
@rhamilto rhamilto deleted the CONSOLE-3202-2 branch January 10, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/sdk Related to console-plugin-sdk do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants