New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-1829: use service port name instead targetPort in the Pipeline Event listener route #12148
OCPBUGS-1829: use service port name instead targetPort in the Pipeline Event listener route #12148
Conversation
@vikram-raj: This pull request references Jira Issue OCPBUGS-1829, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@vikram-raj: This pull request references Jira Issue OCPBUGS-1829, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @karthikjeeyar |
@@ -43,7 +43,7 @@ export const exposeRoute = async (elName: string, ns: string, iteration = 0) => | |||
|
|||
// Get the service, find out what port we are exposed on | |||
const serviceResource = await k8sGet(ServiceModel, serviceGeneratedName, ns); | |||
const servicePort = serviceResource.spec?.ports?.[0]?.targetPort; | |||
const servicePort = serviceResource.spec?.ports?.[0]?.name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions and I really don't know the answer 😏
- How does this work together with different Pipeline operator versions?
- Should we maybe fallback to
name
iftargetPort
is not defined? (...targetPort || ...name?) or are we sure that this is now always the name? - Why is no test update needed? 😏 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the doc for the root cause and the solution suggested by the Pipeline team https://docs.google.com/document/d/16VCW6LOzuuaJYvtrS707T6R9dMyp-PoyXNgquCRYHFA/edit?pli=1. It will work with all the pipeline versions and should always be name
.
cc: @karthikjeeyar
/test e2e-gcp-console |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
/retest |
@vikram-raj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karthikjeeyar, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vikram-raj: Jira Issue OCPBUGS-1829: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-1829 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.13 |
@vikram-raj: new pull request created: #12870 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: https://issues.redhat.com/browse/OCPBUGS-1829
Analysis / Root cause: On upgrading to 1.6.2 from 1.5.2 curl command is throwing error
The application is currently not serving requests at this endpoint. It may not have been started or is still starting
. It is happening because in UI we are using service port TargetPort to create the Pipeline Event listener route instead of the service port name.Solution Description: use service port name instead targetPort in the Pipeline Event listener route