Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-1829: use service port name instead targetPort in the Pipeline Event listener route #12148

Merged
merged 1 commit into from May 26, 2023

Conversation

vikram-raj
Copy link
Member

Fixes: https://issues.redhat.com/browse/OCPBUGS-1829

Analysis / Root cause: On upgrading to 1.6.2 from 1.5.2 curl command is throwing error The application is currently not serving requests at this endpoint. It may not have been started or is still starting. It is happening because in UI we are using service port TargetPort to create the Pipeline Event listener route instead of the service port name.

Solution Description: use service port name instead targetPort in the Pipeline Event listener route

@vikram-raj vikram-raj changed the title use service port name instead targetPort in the Pipeline Event listener route OCPBUGS-1829: use service port name instead targetPort in the Pipeline Event listener route Oct 7, 2022
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 7, 2022
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-1829, which is invalid:

  • expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-1829

Analysis / Root cause: On upgrading to 1.6.2 from 1.5.2 curl command is throwing error The application is currently not serving requests at this endpoint. It may not have been started or is still starting. It is happening because in UI we are using service port TargetPort to create the Pipeline Event listener route instead of the service port name.

Solution Description: use service port name instead targetPort in the Pipeline Event listener route

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2022
@vikram-raj
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 7, 2022
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-1829, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

/cc @karthikjeeyar

@@ -43,7 +43,7 @@ export const exposeRoute = async (elName: string, ns: string, iteration = 0) =>

// Get the service, find out what port we are exposed on
const serviceResource = await k8sGet(ServiceModel, serviceGeneratedName, ns);
const servicePort = serviceResource.spec?.ports?.[0]?.targetPort;
const servicePort = serviceResource.spec?.ports?.[0]?.name;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions and I really don't know the answer 😏

  1. How does this work together with different Pipeline operator versions?
  2. Should we maybe fallback to name if targetPort is not defined? (...targetPort || ...name?) or are we sure that this is now always the name?
  3. Why is no test update needed? 😏 😄

Copy link
Member Author

@vikram-raj vikram-raj Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the doc for the root cause and the solution suggested by the Pipeline team https://docs.google.com/document/d/16VCW6LOzuuaJYvtrS707T6R9dMyp-PoyXNgquCRYHFA/edit?pli=1. It will work with all the pipeline versions and should always be name.
cc: @karthikjeeyar

@vikram-raj
Copy link
Member Author

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2023
@jerolimov
Copy link
Member

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 31, 2023
@Lucifergene
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@karthikjeeyar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthikjeeyar, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 89a3e27 into openshift:master May 26, 2023
2 checks passed
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: Jira Issue OCPBUGS-1829: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1829 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-1829

Analysis / Root cause: On upgrading to 1.6.2 from 1.5.2 curl command is throwing error The application is currently not serving requests at this endpoint. It may not have been started or is still starting. It is happening because in UI we are using service port TargetPort to create the Pipeline Event listener route instead of the service port name.

Solution Description: use service port name instead targetPort in the Pipeline Event listener route

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj deleted the ocpbugs-1829 branch May 31, 2023 10:38
@vikram-raj
Copy link
Member Author

/cherry-pick release-4.13

@openshift-cherrypick-robot

@vikram-raj: new pull request created: #12870

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/pipelines Related to pipelines-plugin jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants