CONSOLE-3323: Switch to admin perspective when user navigates directly to a cluster-scoped route and is in the "All Clusters" perspective #12254

TheRealJon · 2022-11-08T16:32:16Z

When manually navigating to a known cluster-scoped route, the console will automatically switch to the admin perspective so that the active cluster context is clear.

openshift-ci · 2022-11-08T16:32:32Z

@TheRealJon: This pull request references Bugzilla bug 2075654, which is invalid:

expected the bug to target the "4.13.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2075654: Switch to admin perspective when user navigates directly to a cluster-scoped route and is in the "All Clusters" perspective

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TheRealJon · 2022-11-08T17:15:19Z

/bugzilla refresh

openshift-ci · 2022-11-08T17:15:29Z

@TheRealJon: This pull request references Bugzilla bug 2075654, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.13.0) matches configured target release for branch (4.13.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frontend/packages/console-app/src/components/detect-perspective/DetectPerspective.tsx

frontend/public/components/utils/link.tsx

openshift-ci · 2022-11-14T17:58:33Z

@TheRealJon: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

CONSOLE-3323: Switch to admin perspective when user navigates directly to a cluster-scoped route and is in the "All Clusters" perspective

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TheRealJon · 2022-11-18T20:05:16Z

/label tide/merge-method-squash

jhadvig · 2022-11-29T08:02:43Z

Hmm so the frontend test is still failing with the same issue. Wondering if its cause by the fact that we are calling the hook inside a hook, but I doubt that.

… to a cluster-scoped route and is in the "All Clusters" perspective

TheRealJon · 2022-11-29T15:47:06Z

Fixed.

TheRealJon · 2022-11-29T15:48:46Z

QE Approver
/assign @yapei

Docs Approver:
/assign @opayne1

PX Approver:
/assign @RickJWagner

RickJWagner · 2022-11-29T15:53:08Z

/label px-approved

opayne1 · 2022-11-29T16:10:41Z

/label docs-approved

TheRealJon · 2022-12-02T14:44:53Z

/retest

TheRealJon · 2022-12-08T16:06:44Z

/retest
timed out

TheRealJon · 2022-12-13T15:33:56Z

/retest
timeout

jhadvig · 2022-12-14T14:00:00Z

/test e2e-gcp-console

rhamilto

/lgtm

openshift-ci · 2022-12-14T14:16:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [TheRealJon,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TheRealJon · 2022-12-16T16:15:42Z

/retest
timed out

TheRealJon · 2022-12-20T22:26:09Z

/retest
known flake

openshift-ci · 2022-12-21T02:16:23Z

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

yapei · 2023-01-05T07:05:53Z

frontend/public/components/utils/link.tsx

+  '/dashboards',
+  '/settings',
+  '/api-explorer',
+  '/catalog',


/catalog route is in dev perspective

also do we need list all cluster-scope URL here? it looks like some URLs are missing here, for example if I go to following URLs , I will still stay in ACM perspective

/k8s/cluster/core~v1~Namespace /k8s/cluster/apiextensions.k8s.io~v1~CustomResourceDefinition /k8s/cluster/config.openshift.io~v1~Infrastructure/cluster

TheRealJon · 2023-01-05T21:38:04Z

/hold

Rethinking how we can solve this issue. I don't think it's safe to assume single/multi cluster context from navigation routes.

spadgett

@TheRealJon What is the scenario here? You're in the "All Clusters" perspective and someone sends you a link? Or do you have to manually edit the URL?

cc @KevinFCormier

spadgett · 2023-01-26T14:42:13Z

frontend/packages/console-app/src/components/detect-perspective/DetectPerspective.tsx

+  const clusterRouteMatch = useRouteMatch({ path: CLUSTER_SCOPED_ROUTES });
+  const isMulticlusterPerspective = activePerspective === 'acm';
+  const overrideClusterScope = !perspectiveParam && clusterRouteMatch && isMulticlusterPerspective;
+  const overridePerspective = overrideClusterScope ? 'admin' : perspectiveParam;


Note that the admin perspective can be disabled in the cluster config.

spadgett · 2023-01-26T14:42:54Z

frontend/public/components/utils/link.tsx

@@ -33,6 +33,17 @@ export const namespacedPrefixes = [
  '/status',
 ];

+export const CLUSTER_SCOPED_ROUTES = [


I worry about having a hard-coded list of paths that we need to maintain. It also means we won't be able to support routes contributed by plugins.

KevinFCormier · 2023-01-26T15:21:11Z

My thought was to switch the current cluster to local-cluster when using All Clusters, so that ACM links out to console pages will be for the correct cluster. But I suppose if you followed a link to an ACM page, the perspective doesn't change automatically, so my approach would leave that gap.

TheRealJon · 2023-02-01T16:32:01Z

We've decided against this approach for handling cluster context for now. We may need to revisit, but for now, I will close this PR.

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 8, 2022

openshift-ci bot requested review from dtaylor113 and jcaianirh November 8, 2022 16:34

openshift-ci bot added component/core Related to console core functionality component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 8, 2022

TheRealJon force-pushed the 2075654 branch from 80d8582 to 48df8f2 Compare November 8, 2022 16:35

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 8, 2022

openshift-ci bot requested a review from yapei November 8, 2022 17:15

TheRealJon force-pushed the 2075654 branch from 48df8f2 to 77716aa Compare November 8, 2022 17:17

jhadvig reviewed Nov 11, 2022

View reviewed changes

frontend/packages/console-app/src/components/detect-perspective/DetectPerspective.tsx Outdated Show resolved Hide resolved

frontend/public/components/utils/link.tsx Outdated Show resolved Hide resolved

frontend/public/components/utils/link.tsx Outdated Show resolved Hide resolved

openshift-ci bot removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 14, 2022

TheRealJon force-pushed the 2075654 branch from d2497ff to 4ee5f8d Compare November 18, 2022 20:04

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 18, 2022

TheRealJon force-pushed the 2075654 branch from 4ee5f8d to aa6e5fc Compare November 28, 2022 17:03

TheRealJon added 3 commits November 29, 2022 10:45

Bug 2075654: Switch to admin perspective when user navigates directly…

452f004

… to a cluster-scoped route and is in the "All Clusters" perspective

Add monitoring and any namespaced path to cluster scoped routes.

39ca659

Update DetectPerspective unit tests

3e84a51

TheRealJon force-pushed the 2075654 branch from aa6e5fc to 3e84a51 Compare November 29, 2022 15:46

openshift-ci bot assigned opayne1, RickJWagner and yapei Nov 29, 2022

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Nov 29, 2022

RickJWagner removed their assignment Nov 29, 2022

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Nov 29, 2022

rhamilto approved these changes Dec 14, 2022

View reviewed changes

openshift-ci bot assigned rhamilto Dec 14, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2022

yapei reviewed Jan 5, 2023

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2023

spadgett reviewed Jan 26, 2023

View reviewed changes

TheRealJon closed this Feb 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CONSOLE-3323: Switch to admin perspective when user navigates directly to a cluster-scoped route and is in the "All Clusters" perspective #12254

CONSOLE-3323: Switch to admin perspective when user navigates directly to a cluster-scoped route and is in the "All Clusters" perspective #12254

TheRealJon commented Nov 8, 2022

openshift-ci bot commented Nov 8, 2022

TheRealJon commented Nov 8, 2022

openshift-ci bot commented Nov 8, 2022

openshift-ci bot commented Nov 14, 2022 •

edited

TheRealJon commented Nov 18, 2022

jhadvig commented Nov 29, 2022

TheRealJon commented Nov 29, 2022

TheRealJon commented Nov 29, 2022

RickJWagner commented Nov 29, 2022

opayne1 commented Nov 29, 2022

TheRealJon commented Dec 2, 2022

TheRealJon commented Dec 8, 2022

TheRealJon commented Dec 13, 2022

jhadvig commented Dec 14, 2022

rhamilto left a comment

openshift-ci bot commented Dec 14, 2022

TheRealJon commented Dec 16, 2022

TheRealJon commented Dec 20, 2022

openshift-ci bot commented Dec 21, 2022

yapei Jan 5, 2023

yapei Jan 5, 2023

TheRealJon commented Jan 5, 2023

spadgett left a comment

spadgett Jan 26, 2023

spadgett Jan 26, 2023

KevinFCormier commented Jan 26, 2023

TheRealJon commented Feb 1, 2023

CONSOLE-3323: Switch to admin perspective when user navigates directly to a cluster-scoped route and is in the "All Clusters" perspective #12254

CONSOLE-3323: Switch to admin perspective when user navigates directly to a cluster-scoped route and is in the "All Clusters" perspective #12254

Conversation

TheRealJon commented Nov 8, 2022

openshift-ci bot commented Nov 8, 2022

TheRealJon commented Nov 8, 2022

openshift-ci bot commented Nov 8, 2022

openshift-ci bot commented Nov 14, 2022 • edited

TheRealJon commented Nov 18, 2022

jhadvig commented Nov 29, 2022

TheRealJon commented Nov 29, 2022

TheRealJon commented Nov 29, 2022

RickJWagner commented Nov 29, 2022

opayne1 commented Nov 29, 2022

TheRealJon commented Dec 2, 2022

TheRealJon commented Dec 8, 2022

TheRealJon commented Dec 13, 2022

jhadvig commented Dec 14, 2022

rhamilto left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Dec 14, 2022

TheRealJon commented Dec 16, 2022

TheRealJon commented Dec 20, 2022

openshift-ci bot commented Dec 21, 2022

yapei Jan 5, 2023

Choose a reason for hiding this comment

yapei Jan 5, 2023

Choose a reason for hiding this comment

TheRealJon commented Jan 5, 2023

spadgett left a comment

Choose a reason for hiding this comment

spadgett Jan 26, 2023

Choose a reason for hiding this comment

spadgett Jan 26, 2023

Choose a reason for hiding this comment

KevinFCormier commented Jan 26, 2023

TheRealJon commented Feb 1, 2023

openshift-ci bot commented Nov 14, 2022 •

edited