Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring: Use PatternFly components instead of Breadcrumbs component #12303

Merged
merged 1 commit into from Nov 29, 2022
Merged

Monitoring: Use PatternFly components instead of Breadcrumbs component #12303

merged 1 commit into from Nov 29, 2022

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Nov 24, 2022 •
edited

Refactoring for the following pages

  • Observe > Alerting > Alerts
  • Observe > Alerting > Silences
  • Observe > Alerting > Alerting rules
  • Observe > Targets
  • Administration > Cluster Settings > Configuration > Alertmanager

Part of https://issues.redhat.com/browse/OU-41

@kyoto
Monitoring: Use PatternFly components instead of Breadcrumbs component
3bb144a 
Refactoring for the following pages
  - Observe > Alerting > Alerts
  - Observe > Alerting > Silences
  - Observe > Alerting > Alerting rules
  - Observe > Targets
  - Administration > Cluster Settings > Configuration > Alertmanager
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2022
@kyoto
Copy link
Member Author

kyoto commented Nov 24, 2022

This is a refactoring change. There should be no user visible changes.

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 24, 2022
@kyoto
Copy link
Member Author

kyoto commented Nov 24, 2022

/retest

@jgbernalp
Copy link
Contributor

/lgtm 👍🏽

@jgbernalp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, kyoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyoto
Copy link
Member Author

kyoto commented Nov 24, 2022

/retest

3 similar comments
@kyoto
Copy link
Member Author

kyoto commented Nov 24, 2022

/retest

@kyoto
Copy link
Member Author

kyoto commented Nov 26, 2022

/retest

@kyoto
Copy link
Member Author

kyoto commented Nov 27, 2022

/retest

@lihongyan1
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 28, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD fe41d25 and 2 for PR HEAD 3bb144a in total

@cyril-ui-developer
Copy link
Contributor

/test e2e-gcp-console

@kyoto
Copy link
Member Author

kyoto commented Nov 29, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2022

@kyoto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0ce4fcc into openshift:master Nov 29, 2022
@kyoto kyoto deleted the monitoring-plugin-breadcrumbs branch November 29, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett Awaiting requested review from spadgett

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@jgbernalp jgbernalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kyoto @jgbernalp @lihongyan1 @openshift-ci-robot @cyril-ui-developer @openshift-merge-robot