Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-4352: bump HorizontalPodAutoscaler to v2 and add redirect for… #12339

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Dec 5, 2022

… v2beta2

No changes between v2beta1 and v2 per https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v125.

And

Warning: autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler

After:

Screen.Recording.2022-12-05.at.12.12.17.PM.mov

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 5, 2022
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-4352, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

… v2beta2

No changes between v2beta1 and v2 per https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v125.

After:

Screen.Recording.2022-12-05.at.12.12.17.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-4352, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

… v2beta2

No changes between v2beta1 and v2 per https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v125.

And

Warning: autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler

After:

Screen.Recording.2022-12-05.at.12.12.17.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto
Copy link
Member Author

rhamilto commented Dec 5, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 5, 2022
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-4352, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin component/shared Related to console-shared labels Dec 5, 2022
@rhamilto
Copy link
Member Author

rhamilto commented Dec 5, 2022

/retest

5 similar comments
@rhamilto
Copy link
Member Author

rhamilto commented Dec 5, 2022

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Dec 6, 2022

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Dec 6, 2022

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Dec 6, 2022

/retest

@jhadvig
Copy link
Member

jhadvig commented Dec 7, 2022

/retest

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhamilto the changes look good, but after checking the API types I see that there is an extra field in the HPA spec, called Behavior . Check v2beta1 and v2 specs. Also checked if there are any other changes in the status but looks like its the same.
We should update the HPA kind in https://github.com/openshift/console/blob/master/frontend/public/module/k8s/types.ts#L432

@rhamilto
Copy link
Member Author

rhamilto commented Dec 7, 2022

/label tide/merge-method-squash
/retest

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 7, 2022
@rhamilto
Copy link
Member Author

rhamilto commented Dec 7, 2022

@rhamilto the changes look good, but after checking the API types I see that there is an extra field in the HPA spec, called Behavior . Check v2beta1 and v2 specs. Also checked if there are any other changes in the status but looks like its the same. We should update the HPA kind in https://github.com/openshift/console/blob/master/frontend/public/module/k8s/types.ts#L432

Added. 6679a4d

@rhamilto
Copy link
Member Author

rhamilto commented Dec 7, 2022

/retest

1 similar comment
@rhamilto
Copy link
Member Author

rhamilto commented Dec 7, 2022

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Dec 9, 2022

@jhadvig, mind taking another look?

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rhamilto 👍
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3848ae5 into openshift:master Dec 13, 2022
@openshift-ci-robot
Copy link
Contributor

@rhamilto: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4352 has been moved to the MODIFIED state.

In response to this:

… v2beta2

No changes between v2beta1 and v2 per https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v125.

And

Warning: autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler

After:

Screen.Recording.2022-12-05.at.12.12.17.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto deleted the OCPBUGS-4352 branch December 13, 2022 12:15
@rhamilto
Copy link
Member Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@rhamilto: new pull request created: #13269

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants