Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-5263: only show upgrade details if cluster not externally man… #12404

Merged
merged 1 commit into from Jan 18, 2023
Merged

[release-4.12] OCPBUGS-5263: only show upgrade details if cluster not externally man… #12404

merged 1 commit into from Jan 18, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #12362

/assign rhamilto

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 3, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-4700 has been cloned as Jira Issue OCPBUGS-5263. Retitling PR to link against new bug.
/retitle [release-4.12] OCPBUGS-5263: only show upgrade details if cluster not externally man…

In response to this:

This is an automated cherry-pick of #12362

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-4700: only show upgrade details if cluster not externally man… [release-4.12] OCPBUGS-5263: only show upgrade details if cluster not externally man… Jan 3, 2023
@openshift-ci-robot openshift-ci-robot added the jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. label Jan 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-5263: only show upgrade details if cluster not externally man…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 3, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5263, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-4700 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-4700 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #12362

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jan 3, 2023
@rhamilto
Copy link
Member

rhamilto commented Jan 3, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 3, 2023
@rhamilto
Copy link
Member

rhamilto commented Jan 3, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@rhamilto
Copy link
Member

rhamilto commented Jan 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member

rhamilto commented Jan 3, 2023

/retest

2 similar comments
@rhamilto
Copy link
Member

rhamilto commented Jan 3, 2023

/retest

@rhamilto
Copy link
Member

rhamilto commented Jan 3, 2023

/retest

@XiyunZhao
Copy link

This PR has been verified by using cluster-bot, now when the cluster is externally managed the update blocked information will be hidden on the cluster setting page
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 16, 2023
@yapei
Copy link
Contributor

yapei commented Jan 17, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 17, 2023
@rhamilto
Copy link
Member

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b237c34 and 2 for PR HEAD 7d3c21c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7d30157 into openshift:release-4.12 Jan 18, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5263 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #12362

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yapei yapei Awaiting requested review from yapei

@jhadvig jhadvig Awaiting requested review from jhadvig

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@rhamilto rhamilto

@gouyang gouyang

@jrichter1 jrichter1

@ebenahar ebenahar

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@juzhao juzhao

@nehaberry nehaberry

@lihongyan1 lihongyan1

@hemantsaini-7 hemantsaini-7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet