OCPBUGS-3822: improve subscription exists alert message #12454

rhamilto · 2023-01-20T20:59:40Z

Updated alert:

In order to avoid the following error when deleting the existing Subscription, we need to first check if the CSV exists before trying to delete it in the event it was already deleted:

openshift-ci-robot · 2023-01-20T20:59:46Z

@rhamilto: This pull request references Jira Issue OCPBUGS-3822, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Updated alert:

Need to discuss what to do about error when deleting the existing Subscription as this is confusing since the CSV was already deleted:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-20T21:09:02Z

@rhamilto: This pull request references Jira Issue OCPBUGS-3822, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

In response to this:

Updated alert:

Need to discuss what to do about error when deleting the existing Subscription as this is confusing since the CSV was already deleted:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2023-01-24T15:26:27Z

@tlwu2013, thoughts on the error in the Uninstall Operator? modal when deleting the existing Subscription since the CSV was already deleted? See https://issues.redhat.com/browse/OCPBUGS-3822 for full details.

openshift-ci-robot · 2023-01-25T15:52:11Z

@rhamilto: This pull request references Jira Issue OCPBUGS-3822, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

In response to this:

Updated alert:

In order to avoid the following error when deleting the existing Subscription, we need to first check if the CSV exists before trying to delete it in the event it was already deleted:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-25T15:52:38Z

@rhamilto: This pull request references Jira Issue OCPBUGS-3822, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

In response to this:

Updated alert:

In order to avoid the following error when deleting the existing Subscription, we need to first check if the CSV exists before trying to delete it in the event it was already deleted:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-25T17:03:08Z

@rhamilto: This pull request references Jira Issue OCPBUGS-3822, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

In response to this:

Updated alert:

In order to avoid the following error when deleting the existing Subscription, we need to first check if the CSV exists before trying to delete it in the event it was already deleted:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2023-01-26T13:00:18Z

/retest

rhamilto · 2023-01-26T16:50:31Z

/retest

rhamilto · 2023-01-26T18:29:39Z

/hold

broke test

rhamilto · 2023-01-30T13:51:20Z

/hold cancel

test fixed

rhamilto · 2023-01-31T16:26:16Z

@TheRealJon, mind reviewing?

rhamilto · 2023-02-13T13:43:33Z

@TheRealJon or @jhadvig, mind reviewing so we can get this bug closed?

jhadvig

/lgtm
/approve

TheRealJon

I don't think we can assume that a failed request for the installed CSV means it doesn't exist. Do we need a different message for the case where we can't determine the existence of the CSV due to a failed response other than a 404?

TheRealJon · 2023-02-14T19:06:52Z

frontend/packages/operator-lifecycle-manager/src/components/modals/uninstall-operator-modal.tsx

+    const clusterServiceVersionExists = async () => {
+      try {
+        await k8sGetResource({
+          model: ClusterServiceVersionModel,
+          name: subscription.status.installedCSV,
+          ns: subscription.metadata.namespace,
+        });
+        return true;
+      } catch (err) {
+        // eslint-disable-next-line no-console
+        console.log(err.message);
+        return false;
+      }
+    };


What happens when the request fails with something other than a 404?

Good point. We need to report out those other errors.

/hold

rhamilto · 2023-02-14T22:23:02Z

frontend/packages/operator-lifecycle-manager/src/components/modals/uninstall-operator-modal.tsx

+        });
+        return true;
+      } catch (err) {
+        if (err.json.code !== 404) {


@TheRealJon, updated. PTAL.

rhamilto · 2023-02-14T22:23:41Z

/label tide/merge-method-squash

rhamilto · 2023-02-15T13:51:04Z

/retest

TheRealJon

/lgtm

openshift-ci · 2023-02-15T16:07:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/operator-lifecycle-manager/OWNERS~~ [TheRealJon,jhadvig,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhamilto · 2023-02-15T18:51:03Z

/retest

rhamilto · 2023-02-15T23:29:26Z

/retest

rhamilto · 2023-02-16T13:42:05Z

/retest

rhamilto · 2023-02-16T18:36:41Z

/retest

rhamilto · 2023-02-17T13:30:29Z

/retest

rhamilto · 2023-02-17T18:18:46Z

/hold cancel

openshift-ci-robot · 2023-02-18T02:11:20Z

/retest-required

Remaining retests: 0 against base HEAD 74bae5f and 2 for PR HEAD c373d17 in total

openshift-ci · 2023-02-18T06:40:02Z

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-02-18T07:27:35Z

@rhamilto: All pull requests linked via external trackers have merged:

openshift/console#12454

Jira Issue OCPBUGS-3822 has been moved to the MODIFIED state.

In response to this:

Updated alert:

In order to avoid the following error when deleting the existing Subscription, we need to first check if the CSV exists before trying to delete it in the event it was already deleted:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 20, 2023

openshift-ci bot requested review from XiyunZhao, spadgett and TheRealJon January 20, 2023 20:59

openshift-ci bot added component/olm Related to OLM kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2023

rhamilto force-pushed the OCPBUGS-3822 branch from 99ae2dd to 66e0888 Compare January 20, 2023 21:08

rhamilto force-pushed the OCPBUGS-3822 branch from 66e0888 to 7681fba Compare January 25, 2023 15:46

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 25, 2023

rhamilto assigned TheRealJon Jan 25, 2023

rhamilto force-pushed the OCPBUGS-3822 branch from 7681fba to 9d7ef14 Compare January 25, 2023 17:02

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2023

OCPBUGS-3822: improve subscription exists alert message

5e31990

rhamilto force-pushed the OCPBUGS-3822 branch from 9d7ef14 to 5e31990 Compare January 30, 2023 13:51

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2023

jhadvig approved these changes Feb 14, 2023

View reviewed changes

openshift-ci bot assigned jhadvig Feb 14, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023

TheRealJon reviewed Feb 14, 2023

View reviewed changes

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 14, 2023

Catch non-404 errors and display them

c373d17

rhamilto force-pushed the OCPBUGS-3822 branch from 705909b to c373d17 Compare February 14, 2023 22:16

rhamilto commented Feb 14, 2023

View reviewed changes

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 14, 2023

TheRealJon approved these changes Feb 15, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2023

openshift-merge-robot merged commit ab43e3e into openshift:master Feb 18, 2023

rhamilto deleted the OCPBUGS-3822 branch February 18, 2023 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-3822: improve subscription exists alert message #12454

OCPBUGS-3822: improve subscription exists alert message #12454

rhamilto commented Jan 20, 2023 •

edited

openshift-ci-robot commented Jan 20, 2023

openshift-ci-robot commented Jan 20, 2023

rhamilto commented Jan 24, 2023

openshift-ci-robot commented Jan 25, 2023

openshift-ci-robot commented Jan 25, 2023

openshift-ci-robot commented Jan 25, 2023

rhamilto commented Jan 26, 2023

rhamilto commented Jan 26, 2023

rhamilto commented Jan 26, 2023

rhamilto commented Jan 30, 2023

rhamilto commented Jan 31, 2023

rhamilto commented Feb 13, 2023

jhadvig left a comment

TheRealJon left a comment

TheRealJon Feb 14, 2023

rhamilto Feb 14, 2023

rhamilto Feb 14, 2023

rhamilto commented Feb 14, 2023

rhamilto commented Feb 15, 2023

TheRealJon left a comment

openshift-ci bot commented Feb 15, 2023

rhamilto commented Feb 15, 2023

rhamilto commented Feb 15, 2023

rhamilto commented Feb 16, 2023

rhamilto commented Feb 16, 2023

rhamilto commented Feb 17, 2023

rhamilto commented Feb 17, 2023

openshift-ci-robot commented Feb 18, 2023

openshift-ci bot commented Feb 18, 2023

openshift-ci-robot commented Feb 18, 2023

OCPBUGS-3822: improve subscription exists alert message #12454

OCPBUGS-3822: improve subscription exists alert message #12454

Conversation

rhamilto commented Jan 20, 2023 • edited

openshift-ci-robot commented Jan 20, 2023

openshift-ci-robot commented Jan 20, 2023

rhamilto commented Jan 24, 2023

openshift-ci-robot commented Jan 25, 2023

openshift-ci-robot commented Jan 25, 2023

openshift-ci-robot commented Jan 25, 2023

rhamilto commented Jan 26, 2023

rhamilto commented Jan 26, 2023

rhamilto commented Jan 26, 2023

rhamilto commented Jan 30, 2023

rhamilto commented Jan 31, 2023

rhamilto commented Feb 13, 2023

jhadvig left a comment

Choose a reason for hiding this comment

TheRealJon left a comment

Choose a reason for hiding this comment

TheRealJon Feb 14, 2023

Choose a reason for hiding this comment

rhamilto Feb 14, 2023

Choose a reason for hiding this comment

rhamilto Feb 14, 2023

Choose a reason for hiding this comment

rhamilto commented Feb 14, 2023

rhamilto commented Feb 15, 2023

TheRealJon left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Feb 15, 2023

rhamilto commented Feb 15, 2023

rhamilto commented Feb 15, 2023

rhamilto commented Feb 16, 2023

rhamilto commented Feb 16, 2023

rhamilto commented Feb 17, 2023

rhamilto commented Feb 17, 2023

openshift-ci-robot commented Feb 18, 2023

openshift-ci bot commented Feb 18, 2023

openshift-ci-robot commented Feb 18, 2023

rhamilto commented Jan 20, 2023 •

edited