Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-6764: Add Git Repository (PAC) showed empty permission content and non-working help link until a git url is entered #12490

Merged
merged 1 commit into from Feb 2, 2023
Merged

[release-4.12] OCPBUGS-6764: Add Git Repository (PAC) showed empty permission content and non-working help link until a git url is entered #12490

merged 1 commit into from Feb 2, 2023

Conversation

jerolimov
Copy link
Member

This is a manual backport of #12445

Screen recording:

ocpbugs-6764.mp4

@openshift-ci-robot openshift-ci-robot added the jira/severity-informational Referenced Jira bug's severity is informational for the PR. label Jan 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2023

@jerolimov: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-6764: Add Git Repository (PAC) showed empty permission content and non-working help link until a git url is entered

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2023
@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-6764, which is invalid:

  • expected the bug to target the "4.12.z" version, but it targets "4.13.0" instead
  • expected Jira Issue OCPBUGS-6764 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual backport of #12445

Screen recording:

ocpbugs-6764.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 29, 2023
@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 29, 2023
@jerolimov
Copy link
Member Author

/cc @vikram-raj @sanketpathak @hemantsaini-7

vikram-raj
vikram-raj reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it on 4.12 cluster bot

/lgtm
Peek 2023-01-30 15-31
image

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikram-raj
Copy link
Member

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@vikram-raj: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 31, 2023
@jerolimov
Copy link
Member Author

/jira refresh
/cc @sanketpathak @hemantsaini-7

@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-6764, which is invalid:

  • expected the bug to target the "4.12.z" version, but it targets "4.13.0" instead
  • expected Jira Issue OCPBUGS-6764 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh
/cc @sanketpathak @hemantsaini-7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 31, 2023
@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-6764, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-5997 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-5997 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hemantsaini-7
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 31, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3546449 and 2 for PR HEAD 558aa16 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 51e2299 and 1 for PR HEAD 558aa16 in total

@jerolimov
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2023

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3225be8 into openshift:release-4.12 Feb 2, 2023
@openshift-ci-robot
Copy link
Contributor

@jerolimov: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6764 has been moved to the MODIFIED state.

In response to this:

This is a manual backport of #12445

Screen recording:

ocpbugs-6764.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

/cherry-pick release-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 2, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jerolimov: new pull request created: #12523

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov jerolimov deleted the OCPBUGS-6764 branch August 7, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@hemantsaini-7 hemantsaini-7 Awaiting requested review from hemantsaini-7

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@gouyang gouyang

@vikram-raj vikram-raj

@jrichter1 jrichter1

@ebenahar ebenahar

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@juzhao juzhao

@lihongyan1 lihongyan1

@hemantsaini-7 hemantsaini-7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/pipelines Related to pipelines-plugin jira/severity-informational Referenced Jira bug's severity is informational for the PR. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet