CONSOLE-3431: Allow building dynamic plugins without any exposed modules

[vojtechszocs]

Fixes CONSOLE-3431

This is a backport of a fix from openshift/dynamic-plugin-sdk#199.

How to verify this fix:

# [1] Update Console dependencies and rebuild its plugin SDK
cd /path/to/console/frontend
yarn install

# [2] Simulate a use case where a plugin has no exposed modules
cd /path/to/console/dynamic-demo-plugin
rm -rf node_modules/@openshift-console && yarn install --check-files
# Manual step: edit package.json and remove consolePlugin.exposedModules
CONSOLE_PLUGIN_SKIP_EXT_VALIDATOR=true yarn build-dev

The demo plugin should now build without errors even if it doesn't provide any exposed modules.

[vojtechszocs]

/retest

[vojtechszocs]

/retest

[vojtechszocs]

/retest

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-ci-robot]

@vojtechszocs: This pull request references CONSOLE-3431 which is a valid jira issue.

In response to this:

Fixes CONSOLE-3431

This is a backport of a fix from openshift/dynamic-plugin-sdk#199.

How to verify this fix:

# [1] Update Console dependencies and rebuild its plugin SDK
cd /path/to/console/frontend
yarn install

# [2] Simulate a use case where a plugin has no exposed modules
cd /path/to/console/dynamic-demo-plugin
# Edit package.json and remove consolePlugin.exposedModules
CONSOLE_PLUGIN_SKIP_EXT_VALIDATOR=true yarn build-dev

The demo plugin should now build without errors even if it doesn't provide any exposed modules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

/remove-lifecycle rotten

[spadgett]

Sorry I missed this.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• dynamic-demo-plugin/OWNERS [spadgett,vojtechszocs]
• frontend/packages/console-dynamic-plugin-sdk/OWNERS [spadgett,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vojtechszocs]

/retest

[vojtechszocs]

This removes the plugin build constraint that each plugin must provide at least one exposed module.

No impact for existing plugins.

[openshift-ci-robot]

@vojtechszocs: This pull request references CONSOLE-3431 which is a valid jira issue.

In response to this:

Fixes CONSOLE-3431

This is a backport of a fix from openshift/dynamic-plugin-sdk#199.

How to verify this fix:

# [1] Update Console dependencies and rebuild its plugin SDK
cd /path/to/console/frontend
yarn install

# [2] Simulate a use case where a plugin has no exposed modules
cd /path/to/console/dynamic-demo-plugin
rm -rf node_modules/@openshift-console && yarn install --check-files
# Manual step: edit package.json and remove consolePlugin.exposedModules
CONSOLE_PLUGIN_SKIP_EXT_VALIDATOR=true yarn build-dev

The demo plugin should now build without errors even if it doesn't provide any exposed modules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vojtechszocs]

Requesting approvals:

QE Approver:

/assign @yanpzhan
Docs Approver:

/assign @ahardin-rh
PX Approver:
/assign @RickJWagner

No impact on existing plugins.

[RickJWagner]

/label px-approved

[yanpzhan]

/label qe-approved

[opayne1]

/label docs-approved

[openshift-ci]

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.