OCPBUGS-7427: Associate wait time with method to decrease run time #12559
Conversation
openshift-ci-robot
added
jira/severity-low
|
@rhamilto: This pull request references Jira Issue OCPBUGS-7427, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
kind/cypress
rhamilto
force-pushed
the
OCPBUGS-7427
branch
from
31580b4
to
2d842cd
Compare
| @@ -13,13 +13,15 @@ const PLUGIN_PULL_SPEC = Cypress.env('PLUGIN_PULL_SPEC'); | |||
| /* The update wait is the value to wait for the poll of /api/check-updates to return with the updated list of plugins | |||
| after the plugin is enabled and loaded. This wait will be longer on ci than when debugging locally. */ | |||
| const CHECK_UPDATE_WAIT = 300000; | |||
| const WAIT_OPTIONS = { requestTimeout: CHECK_UPDATE_WAIT }; | |||
There was a problem hiding this comment.
nit: I'd inline this since it's only used once
There was a problem hiding this comment.
Thanks, @spadgett. I had a version that was reusing this and forgot to clean up.
|
/retest |
1 similar comment
|
/retest |
| cy.log(`Running plugin test on ci using PLUGIN_PULL_SPEC: ${PLUGIN_PULL_SPEC}`); | ||
| } | ||
| cy.get(warningToast) | ||
| cy.byTestID(refreshWebConsoleLink, { timeout: CHECK_UPDATE_WAIT }) |
There was a problem hiding this comment.
@rhamilto we've had some issues in the past with the toast notification firing. Do you think we should be testing for the rendering of the toast notification here?
There was a problem hiding this comment.
Not sure I follow. This change is to simply use a better selector for the toast notification and to extend the timeout to 5 minutes so the fixed wait is not required.
There was a problem hiding this comment.
@rhamilto i see now, i thought the check was removed but i see it was just the toast and not the refresh link
| cy.log(`Running plugin test on ci using PLUGIN_PULL_SPEC: ${PLUGIN_PULL_SPEC}`); | ||
| } | ||
| cy.get(warningToast) | ||
| cy.byTestID(refreshWebConsoleLink, { timeout: CHECK_UPDATE_WAIT }) |
There was a problem hiding this comment.
@rhamilto i see now, i thought the check was removed but i see it was just the toast and not the refresh link
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
/hold Revision 2d842cd was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
|
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@rhamilto: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-7427 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.