OCPBUGS-10224: Multiple instances of tabs under ODF dashboard #12635

TimothyAsirJeyasing · 2023-03-10T10:28:08Z

No description provided.

openshift-ci · 2023-03-10T10:28:43Z

Hi @TimothyAsirJeyasing. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TimothyAsirJeyasing · 2023-03-10T11:37:09Z

@SanjalKatiyar Please review

SanjalKatiyar · 2023-03-10T11:42:34Z

remove all the static extensions for which we have already added corresponding dynamic ones... do the same for console-extensions.json that we have for us...

openshift-ci · 2023-03-13T09:07:23Z

@TimothyAsirJeyasing: This pull request references Bugzilla bug 2124829, which is invalid:

expected the bug to target the "4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2124829: Multiple instances of tabs under ODF dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TimothyAsirJeyasing · 2023-03-14T07:08:06Z

/retitle OCPBUGS-10224: Multiple instances of tabs under ODF dashboard

openshift-ci · 2023-03-14T07:08:32Z

@TimothyAsirJeyasing: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle OCPBUGS-10224: Multiple instances of tabs under ODF dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-14T07:08:53Z

@TimothyAsirJeyasing: This pull request references Jira Issue OCPBUGS-10224, which is invalid:

expected the bug to target the "4.14.0" version, but it targets "4.13.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-14T07:08:54Z

@TimothyAsirJeyasing: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-10224: Multiple instances of tabs under ODF dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2023-03-14T07:25:19Z

/jira refresh
/ok-to-test

openshift-ci-robot · 2023-03-14T07:25:27Z

@bipuladh: This pull request references Jira Issue OCPBUGS-10224, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-14T07:26:16Z

@bipuladh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/jira refresh
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2023-03-14T10:43:54Z

/hold

TimothyAsirJeyasing · 2023-03-20T07:49:41Z

@SanjalKatiyar please review

SanjalKatiyar · 2023-03-21T08:00:46Z

frontend/packages/ceph-storage-plugin/src/plugin.ts

-  {
-    type: 'ModelDefinition',
-    properties: {
-      models: _.values(models),
-    },
-  },


we need this... we are not setting this in odf-console...
please refer to previous comments... as mentioned earlier... we only need to remove those extensions for which we do not have corresponding dynamic extensions added in odf-console...
please just don;t remove anything without checking thoroughly...

Ok Sure, I do not see any failure after i remove this with our without ODF installed.

SanjalKatiyar · 2023-03-21T08:02:03Z

frontend/packages/ceph-storage-plugin/src/plugin.ts

-      flag: OCS_MODEL_FLAG,
-    },
-  },
+const plugin = [
  {
    type: 'FeatureFlag/Model',
    properties: {
      model: models.StorageSystemModel,
      flag: ODF_MODEL_FLAG,
    },
  },


I don;t think this is needed... where is it used in odf-console (and if used, are we not setting already in odf-console) ??

When i remove this ODF_MODEL_FLAG flag, i could see the "Data Foundation" link visible on the left side even when we do not have ODF operator installed.

did u check whether odf-console is setting this flag or not ?

odf-console is not setting the default value to false where as its setting to true only.

odf-console will only be present when ODF operator is present...
once odf-console is there, it will set flag to true...

Ok, but when i remove this flag from console repo, I see the ui keep failing and in some browser i could see Data Foundation link. Whereas i could see this issue going away when i set initial value to this flag in odf-console repo.

So we can keep the flag for now right and can remove it once we have fix in place at odf-console ?

I don;t think doing that will cause the issue which u mentioned above... plz make sure u r running local servers correctly...

Found the same issue with fresh build also. In odf-console we are setting the flag value to true without checking anything (setODFFlag). I found It works by adding a (namespace) check and set the value.
Please suggest me further ...

alfonsomthd · 2023-03-21T09:17:08Z

/ok-to-test

TimothyAsirJeyasing · 2023-04-03T21:02:15Z

/test frontend

TimothyAsirJeyasing · 2023-04-05T08:23:29Z

/test frontend

TimothyAsirJeyasing · 2023-04-11T20:44:25Z

/test frontend

Signed-off-by: Timothy Asir <tjeyasin@redhat.com>

TimothyAsirJeyasing · 2023-04-17T03:58:56Z

/test e2e-gcp-console

TimothyAsirJeyasing · 2023-04-17T11:04:16Z

/test e2e-gcp-console

openshift-ci · 2023-04-17T15:08:54Z

@TimothyAsirJeyasing: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bipuladh · 2023-04-18T08:27:45Z

/approve
/lgtm

openshift-ci · 2023-04-18T08:28:46Z

@bipuladh: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TimothyAsirJeyasing · 2023-04-19T09:29:56Z

multi-tab.mp4

SanjalKatiyar · 2023-04-19T11:08:30Z

/hold cancel

SanjalKatiyar · 2023-04-19T11:08:49Z

/approve /lgtm

/approve
/lgtm

jhadvig

/approve

openshift-ci · 2023-04-19T12:03:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, jhadvig, SanjalKatiyar, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-04-19T20:40:48Z

@TimothyAsirJeyasing: Jira Issue OCPBUGS-10224: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10224 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 10, 2023

openshift-ci bot requested review from cloudbehl and jhadvig March 10, 2023 10:28

openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Mar 10, 2023

TimothyAsirJeyasing changed the title ~~Bug Multiple instances of tabs under ODF dashboard~~ Bug 2124829 Multiple instances of tabs under ODF dashboard Mar 10, 2023

TimothyAsirJeyasing force-pushed the Multi-instances-tabs-under-ODF branch from 9508441 to cd6116f Compare March 13, 2023 09:04

TimothyAsirJeyasing changed the title ~~Bug 2124829 Multiple instances of tabs under ODF dashboard~~ Bug 2124829: Multiple instances of tabs under ODF dashboard Mar 13, 2023

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 13, 2023

TimothyAsirJeyasing changed the title ~~Bug 2124829: Multiple instances of tabs under ODF dashboard~~ OCPBUGS-10224: Multiple instances of tabs under ODF dashboard Mar 14, 2023

openshift-ci bot removed the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Mar 14, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 14, 2023

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 14, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2023

TimothyAsirJeyasing force-pushed the Multi-instances-tabs-under-ODF branch from 01341cd to b657c9f Compare March 20, 2023 07:46

SanjalKatiyar reviewed Mar 21, 2023

View reviewed changes

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2023

TimothyAsirJeyasing force-pushed the Multi-instances-tabs-under-ODF branch from b657c9f to 0e70cae Compare April 3, 2023 12:52

OCPBUGS-10224: Multiple instances of tabs under ODF dashboard

5a3831a

Signed-off-by: Timothy Asir <tjeyasin@redhat.com>

TimothyAsirJeyasing force-pushed the Multi-instances-tabs-under-ODF branch from 0e70cae to 5a3831a Compare April 16, 2023 17:04

openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Apr 16, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023

openshift-ci bot assigned SanjalKatiyar Apr 19, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023

jhadvig approved these changes Apr 19, 2023

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023

openshift-merge-robot merged commit 0ec29ae into openshift:master Apr 19, 2023
7 checks passed

OCPBUGS-10224: Multiple instances of tabs under ODF dashboard #12635

OCPBUGS-10224: Multiple instances of tabs under ODF dashboard #12635

Conversation

TimothyAsirJeyasing commented Mar 10, 2023

openshift-ci bot commented Mar 10, 2023

TimothyAsirJeyasing commented Mar 10, 2023

SanjalKatiyar commented Mar 10, 2023

openshift-ci bot commented Mar 13, 2023

TimothyAsirJeyasing commented Mar 14, 2023

openshift-ci bot commented Mar 14, 2023

openshift-ci-robot commented Mar 14, 2023

openshift-ci bot commented Mar 14, 2023

bipuladh commented Mar 14, 2023

openshift-ci-robot commented Mar 14, 2023

openshift-ci bot commented Mar 14, 2023

bipuladh commented Mar 14, 2023

TimothyAsirJeyasing commented Mar 20, 2023

SanjalKatiyar Mar 21, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimothyAsirJeyasing Mar 21, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alfonsomthd commented Mar 21, 2023

TimothyAsirJeyasing commented Apr 3, 2023

TimothyAsirJeyasing commented Apr 5, 2023

TimothyAsirJeyasing commented Apr 11, 2023

TimothyAsirJeyasing commented Apr 17, 2023

TimothyAsirJeyasing commented Apr 17, 2023

openshift-ci bot commented Apr 17, 2023

bipuladh commented Apr 18, 2023

openshift-ci bot commented Apr 18, 2023

TimothyAsirJeyasing commented Apr 19, 2023

SanjalKatiyar commented Apr 19, 2023

SanjalKatiyar commented Apr 19, 2023

jhadvig left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Apr 19, 2023

openshift-ci-robot commented Apr 19, 2023

SanjalKatiyar Mar 21, 2023 •

edited

TimothyAsirJeyasing Mar 21, 2023 •

edited