Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.13] CONSOLE-3452: Add patternfly customer feedback extension mechanism to console #12637

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #12611

/assign jcaianirh

Update json file for localization.

Added yarn.lock file for dynamic plugin.

Updated share-feedback, join mailining list URLS

Added code to switch label and description for report a bug.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 12, 2023

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug CONSOLE-3452 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":["Number value expected as the Sprint id."],"errors":{"customfield_12318341":"Operation value must be a string"}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #12611

/assign jcaianirh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Mar 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dlabaj, openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

/hold

Hi, what is the rationale for backporting? We are past feature freeze and should only backport bug fixes.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2023
@yanpzhan
Copy link
Contributor

@dlabaj @spadgett the pr is linked in US https://issues.redhat.com/browse/CONSOLE-3452. I've tested it and no issue is found. Is it a valid pr? If yes, I will add qe label for it.

@jcaianirh
Copy link
Member

jcaianirh commented Mar 14, 2023

@spadgett The thought was that this might be helpful in getting user feedback data for the tech preview version of multi cluster, and that the change might be small enough to backport in to 4.13. If you think this is of significant priority and is small enough to back port then we can move forward with this (by creating the necessary bug to backport into 4.13). Otherwise I can delete this pr and keep the feature in 4.14. cc: @jhadvig

@jcaianirh
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 534c235 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andybraren
Copy link
Contributor

@spadgett Here's a thread with rationale for backporting from @showeimer. If this is low-risk enough, being able to prioritize and act on feedback from 4.13 users before their next upgrade should be worth it. cc @alimobrem

@dlabaj
Copy link
Contributor

dlabaj commented May 15, 2023

@jcaianirh Can we close this?

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 14, 2023
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 13, 2023
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Oct 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants