OCPBUGS-4496: Fix Samples/Snippets tab

[raspbeep]

When creating/editing a resource a Sample/Snippet tab may appear, if a correct ConsoleYAMLSample was previously applied to a cluster.

The logic on showing Samples/Snippets tabs should be as follows(sample is a ConsoleYAMLSample resource without the snippet: true; snippet is a ConsoleYAMLSample resource with the snippet: true):

no sample && no snippet -> no tabs
no sample && snippet -> snippet tab when editing and tab when creating
sample && no snippet -> sample tab when creating and sample tab when editing
sample && snippet -> sample and snippet tab when creating and snippet tab when editing

[openshift-ci-robot]

@raspbeep: This pull request references Jira Issue OCPBUGS-4496, which is invalid:

• expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When creating/editing a resource a Sample/Snippet tab may appear, if a correct ConsoleYAMLSample was previously applied to a cluster.

The logic on showing Samples/Snippets tabs should be as follows(sample is a ConsoleYAMLSample resource without the snippet: true; snippet is a ConsoleYAMLSample resource with the snippet: true):

no sample && no snippet -> no tabs
no sample && snippet -> snippet tab when editing
snippet tab when creating
sample && no snippet -> sample tab when creating
no sample tab when editing
sample && snippet -> sample and snippet tab when creating
only snippet tab when editing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@raspbeep: This pull request references Jira Issue OCPBUGS-4496, which is invalid:

• expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

When creating/editing a resource a Sample/Snippet tab may appear, if a correct ConsoleYAMLSample was previously applied to a cluster.

The logic on showing Samples/Snippets tabs should be as follows(sample is a ConsoleYAMLSample resource without the snippet: true; snippet is a ConsoleYAMLSample resource with the snippet: true):

no sample && no snippet -> no tabs
no sample && snippet -> snippet tab when editing and tab when creating
sample && no snippet -> sample tab when creating and sample tab when editing
sample && snippet -> sample and snippet tab when creating and snippet tab when editing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[raspbeep]

/jira refresh

[openshift-ci-robot]

@raspbeep: This pull request references Jira Issue OCPBUGS-4496, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Hi @raspbeep. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/ok-to-test

[jhadvig]

/ok-to-test

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[jhadvig]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, raspbeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD b9185dd and 2 for PR HEAD 279b762 in total

[jerolimov]

/retest

[jerolimov]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD b01119c and 1 for PR HEAD 279b762 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fa08df4 and 0 for PR HEAD 279b762 in total

[openshift-ci]

@raspbeep: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@raspbeep: Jira Issue OCPBUGS-4496: All pull requests linked via external trackers have merged:

• openshift/console#12642

Jira Issue OCPBUGS-4496 has been moved to the MODIFIED state.

In response to this:

When creating/editing a resource a Sample/Snippet tab may appear, if a correct ConsoleYAMLSample was previously applied to a cluster.

The logic on showing Samples/Snippets tabs should be as follows(sample is a ConsoleYAMLSample resource without the snippet: true; snippet is a ConsoleYAMLSample resource with the snippet: true):

no sample && no snippet -> no tabs
no sample && snippet -> snippet tab when editing and tab when creating
sample && no snippet -> sample tab when creating and sample tab when editing
sample && snippet -> sample and snippet tab when creating and snippet tab when editing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.