Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-10299: Fixes card sizes not even issue when commit info is not available on Environments page #12651

Merged
merged 6 commits into from Apr 23, 2023
Merged

[release-4.13] OCPBUGS-10299: Fixes card sizes not even issue when commit info is not available on Environments page #12651

merged 6 commits into from Apr 23, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #12550

/assign ciiay

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 14, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-10230 has been cloned as Jira Issue OCPBUGS-10299. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-10299: Fixes card sizes not even issue when commit info is not available on Environments page

In response to this:

This is an automated cherry-pick of #12550

/assign ciiay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-10230: Fixes card sizes not even issue when commit info is not available on Environments page [release-4.13] OCPBUGS-10299: Fixes card sizes not even issue when commit info is not available on Environments page Mar 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OCPBUGS-10299: Fixes card sizes not even issue when commit info is not available on Environments page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 14, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-10299, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10230 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-10230 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #12550

/assign ciiay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/gitops Related to gitops-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Mar 14, 2023
@ciiay
Copy link
Contributor

ciiay commented Mar 15, 2023

/test e2e-gcp-console

2 similar comments
@raspbeep
Copy link
Contributor

/test e2e-gcp-console

@ciiay
Copy link
Contributor

ciiay commented Mar 17, 2023

/test e2e-gcp-console

@jerolimov
Copy link
Member

/label backport-risk-assessed
/approve

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 20, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2023
@ciiay
Copy link
Contributor

ciiay commented Apr 20, 2023

Tested non-kam generated applications. Cards size are same when commit information not available. Please refer the below recording.

/lgtm
/qe-approved

Test_4.14_Environments.mov

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciiay, jerolimov, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ciiay
Copy link
Contributor

ciiay commented Apr 20, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 20, 2023
@yapei
Copy link
Contributor

yapei commented Apr 23, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 23, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 78b097c into openshift:release-4.13 Apr 23, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-10299: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10299 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #12550

/assign ciiay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2023-04-27-232707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@sahil143 sahil143 Awaiting requested review from sahil143

Assignees

@gouyang gouyang

@jrichter1 jrichter1

@ebenahar ebenahar

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@juzhao juzhao

@ciiay ciiay

@lihongyan1 lihongyan1

@hemantsaini-7 hemantsaini-7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/gitops Related to gitops-plugin jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet