OCPBUGS-9214: Create button is disabled in Git Import form when git repo url has hyphens in owner part of the url

[lokanandaprabhu]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-9214

Analysis / Root cause:
hyphen in the 2nd character of the name was not allowed due to regular expression check

Solution Description:
Allowed to add hyphen in the 2nd character of the name
Name -
Should contain only letter(a-z) or number(0-9) as first character
Should contain only letter(a-z) or number(0-9) as last character
Should contain only letter(a-z) or number(0-9) or hyphens(-) or dots(.) in between
Should not contain 2 dots consecutively

Screen shots / Gifs for design review:

-------Before-----

-------After----

Unit test coverage report:
NA

Test setup:

1. Go to Developer -> Add -> Import from Git page
2. use the repo url https://github.com/redhat-developer/s2i-dotnetcore-ex.git
3. add /app in the context dir under advanced git options.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-9214, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-9214

Analysis / Root cause:
hyphen in the 2nd character of the name was not allowed due to regular expression check

Solution Description:
Allowed to add hyphen in the 2nd character of the name
Name -
Should contain only letter(a-z) as first character
Should contain only letter(a-z) or number(0-9) as last character
Should contain only letter(a-z) or number(0-9) or hyphens(-) in between
Should not contain 2 hyphens consecutively

Screen shots / Gifs for design review:

-------Before-----

-------After----

Unit test coverage report:
NA

Test setup:

1. Go to Developer -> Add -> Import from Git page
2. use the repo url https://github.com/redhat-developer/s2i-dotnetcore-ex.git
3. add /app in the context dir under advanced git options.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/cc
/assign

[raspbeep]

/test e2e-gcp-console

[jerolimov]

Please update the unit tests related to this change to make clear which cases doesn't work before and which you want or don't want to allow any more.

The old allowed already

adsf-asdf
asdf-asdf-asdf

but not

adsf--asdf
asdf--asdf--asdf

And this might be one of the issues. Two dashes are allowed!

But your negative lookahead looks like you want to deny that.

[lokanandaprabhu]

Two dashes are not allowed on old regex as well but in YAML I am able to create resource with resource name containing two dashes. I will remove that check

---Old regex with two dashes ----

[jerolimov]

/jira refresh

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-9214, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lokanandaprabhu]

/hold

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-9214, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-9214

Analysis / Root cause:
hyphen in the 2nd character of the name was not allowed due to regular expression check

Solution Description:
Allowed to add hyphen in the 2nd character of the name
Name -
Should contain only letter(a-z) or number(0-9) as first character
Should contain only letter(a-z) or number(0-9) as last character
Should contain only letter(a-z) or number(0-9) or hyphens(-) or dots(.) in between
Should not contain 2 dots consecutively

Screen shots / Gifs for design review:

-------Before-----

-------After----

Unit test coverage report:
NA

Test setup:

1. Go to Developer -> Add -> Import from Git page
2. use the repo url https://github.com/redhat-developer/s2i-dotnetcore-ex.git
3. add /app in the context dir under advanced git options.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[lokanandaprabhu]

/unhold

[jerolimov]

Tested different git and container import pages, as well as the pipeline builder and helm imports. Works as expected.

Some helm charts doesn't install successfully when using a name like "4dotnet" and the Helm chart uses the name to create a Service. But this depends on the helm chart and couldn't be handled in our form.

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@lokanandaprabhu: Jira Issue OCPBUGS-9214: All pull requests linked via external trackers have merged:

• openshift/console#12652

Jira Issue OCPBUGS-9214 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-9214

Analysis / Root cause:
hyphen in the 2nd character of the name was not allowed due to regular expression check

Solution Description:
Allowed to add hyphen in the 2nd character of the name
Name -
Should contain only letter(a-z) or number(0-9) as first character
Should contain only letter(a-z) or number(0-9) as last character
Should contain only letter(a-z) or number(0-9) or hyphens(-) or dots(.) in between
Should not contain 2 dots consecutively

Screen shots / Gifs for design review:

-------Before-----

-------After----

Unit test coverage report:
NA

Test setup:

1. Go to Developer -> Add -> Import from Git page
2. use the repo url https://github.com/redhat-developer/s2i-dotnetcore-ex.git
3. add /app in the context dir under advanced git options.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.