Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7281: Provide Column management option for the TaskRuns list page #12689

Merged
merged 1 commit into from Apr 4, 2023
Merged

ODC-7281: Provide Column management option for the TaskRuns list page #12689

merged 1 commit into from Apr 4, 2023

Conversation

aneeshmbhat
Copy link
Contributor

Story:
https://issues.redhat.com/browse/ODC-7281

Description:
Added Button with associated Modal for handling Column Management

Screen shots / Gifs for design review:

ODC-7281.mp4


Unit test coverage report:
WIP

Test setup:

  • Install Pipelines Operator
  • Create a TaskRun

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 30, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 30, 2023 •
edited by openshift-ci bot

@aneeshmbhat: This pull request references ODC-7281 which is a valid jira issue.

In response to this:

Story:
https://issues.redhat.com/browse/ODC-7281

Description:
Added Button with associated Modal for handling Column Management

Screen shots / Gifs for design review:

ODC-7281.mp4


Unit test coverage report:
WIP

Test setup:

  • Install Pipelines Operator
  • Create a TaskRun

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Mar 30, 2023
@aneeshmbhat
Copy link
Contributor Author

/retest

@vikram-raj
Copy link
Member

@aneeshmbhat Frontend tests are failing because the Translation file is not up to date. Please Run yarn i18n locally and update the PR.

@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Mar 30, 2023
@aneeshmbhat aneeshmbhat force-pushed the anebhat-7281 branch 2 times, most recently from 7bb44c4 to 354ea5b Compare March 30, 2023 14:00
@vikram-raj
Copy link
Member

On the first load of the console TaskRuns columns value are empty and Duration Column is visible but the Duration column is not checked.

Peek 2023-03-30 22-28

vikram-raj
vikram-raj reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

Peek 2023-03-31 20-34

/lgtm
/approve

@vikram-raj
Copy link
Member

Propagating docs and px acks from the Epic
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Mar 31, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 31, 2023
hemantsaini-7
hemantsaini-7 reviewed Apr 3, 2023
View reviewed changes
...ges/pipelines-plugin/integration-tests/features/pipelines/pipeline-task-runs-display.feature Outdated
And user clicks on TaskRuns tab
And user clicks manage columns button
And user enables Duration column
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duration column has been already enabled here, so no need to check duration option again, instead we can verify that duration option is already checked.

hemantsaini-7
hemantsaini-7 reviewed Apr 3, 2023
View reviewed changes
...ges/pipelines-plugin/integration-tests/features/pipelines/pipeline-task-runs-display.feature Outdated

@regression
Scenario: Check for Duration column when enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test cases number accordingly. (P-05-TC07)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@hemantsaini-7
Copy link
Contributor

Verified using PR cluster

Screen.Recording.2023-04-03.at.2.21.25.PM.mov

Tests are green
Screenshot 2023-04-03 at 2 24 07 PM

/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 3, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshmbhat, hemantsaini-7, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8f27078 and 2 for PR HEAD 34e6ab2 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

@aneeshmbhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b9207f0 into openshift:master Apr 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj requested changes

@hemantsaini-7 hemantsaini-7 hemantsaini-7 left review comments

@lokanandaprabhu lokanandaprabhu Awaiting requested review from lokanandaprabhu

Assignees

@vikram-raj vikram-raj

@hemantsaini-7 hemantsaini-7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/pipelines Related to pipelines-plugin docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aneeshmbhat @openshift-ci-robot @vikram-raj @hemantsaini-7 @openshift-merge-robot