Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] OCPBUGS-13580: Regression: OpenShift Console no-longer filters SecretList when displaying ServiceAccount #12747

Conversation

cyril-ui-developer
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2023

@cyril-ui-developer: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-6767: Regression: OpenShift Console no-longer filters SecretList when displaying ServiceAccount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-6767, which is invalid:

  • expected the bug to target the "4.12.z" version, but it targets "4.14.0" instead
  • expected Jira Issue OCPBUGS-6767 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 20, 2023
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Apr 20, 2023
@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-6767, which is invalid:

  • expected Jira Issue OCPBUGS-6767 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/assign @rhamilto

@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-6767, which is invalid:

  • expected the bug to target only the "4.12.z" version, but multiple target versions were set
  • expected Jira Issue OCPBUGS-6767 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-6767, which is invalid:

  • expected Jira Issue OCPBUGS-6767 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-6767, which is invalid:

  • expected the bug to target the "4.12.z" version, but it targets "4.13.0" instead
  • expected Jira Issue OCPBUGS-6767 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-6767, which is invalid:

  • expected Jira Issue OCPBUGS-6767 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer cyril-ui-developer changed the title OCPBUGS-6767: Regression: OpenShift Console no-longer filters SecretList when displaying ServiceAccount OCPBUGS-13580: [release4.12]-Regression: OpenShift Console no-longer filters SecretList when displaying ServiceAccount May 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2023

@cyril-ui-developer: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-13580: [release4.12]-Regression: OpenShift Console no-longer filters SecretList when displaying ServiceAccount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-13580, which is invalid:

  • expected Jira Issue OCPBUGS-13580 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-13580, which is invalid:

  • expected Jira Issue OCPBUGS-13580 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-13580, which is invalid:

  • expected dependent Jira Issue OCPBUGS-6767 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig
Copy link
Member

jhadvig commented Sep 25, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 25, 2023
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-13580, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-14265 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-14265 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 25, 2023
@openshift-ci openshift-ci bot requested a review from yapei September 25, 2023 12:19
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
@XiyunZhao
Copy link

Hi @cyril-ui-developer, I tested the PR by using cluster bot (launch 4.12,#12747), but the Secret list is still shown in the ServiceAccount details page, could you help to check?

@cyril-ui-developer
Copy link
Contributor Author

Hi @cyril-ui-developer, I tested the PR by using cluster bot (launch 4.12,#12747), but the Secret list is still shown in the ServiceAccount details page, could you help to check?

@XiyunZhao This is expected for release-4.12 since the change to remove autogenerated secrets was introduced in 4.12.
cc: @rhamilto

@XiyunZhao
Copy link

Hi @cyril-ui-developer, I tested the PR by using cluster bot (launch 4.12,#12747), but the Secret list is still shown in the ServiceAccount details page, could you help to check?

@XiyunZhao This is expected for release-4.12 since the change to remove autogenerated secrets was introduced in 4.12. cc: @rhamilto

Sorry @cyril-ui-developer, I have some misunderstanding here, based on the changes on 4.13-4.15, the secret list is removed from the SA details page, which means list will be no longer shown on the page.
Based on your reply, did you mean that the list will be kept on 4.12 only, and only SA related secret would be shown, is that correct?

@cyril-ui-developer
Copy link
Contributor Author

Hi @cyril-ui-developer, I tested the PR by using cluster bot (launch 4.12,#12747), but the Secret list is still shown in the ServiceAccount details page, could you help to check?

@XiyunZhao This is expected for release-4.12 since the change to remove autogenerated secrets was introduced in 4.12. cc: @rhamilto

Sorry @cyril-ui-developer, I have some misunderstanding here, based on the changes on 4.13-4.15, the secret list is removed from the SA details page, which means list will be no longer shown on the page. Based on your reply, did you mean that the list will be kept on 4.12 only, and only SA related secret would be shown, is that correct?

@XiyunZhao Yes. Sorry for late reply.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, jhadvig, rhamilto, XiyunZhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 10, 2023
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-13580, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-14265 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-14265 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanpzhan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit dea60d8 into openshift:release-4.12 Oct 10, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: Jira Issue OCPBUGS-13580: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13580 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-10-12-030017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet