New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODC-7275: Implement invoke serverless functions #12755
Conversation
@Lucifergene: This pull request references ODC-7275 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/uncc @christianvogt |
@Lucifergene: This pull request references ODC-7275 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@erthalion, I don't remember your design, but do you think the button on the last screen should be |
@Lucifergene: This pull request references ODC-7275 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Lucifergene: This pull request references ODC-7275 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Lucifergene: This pull request references ODC-7275 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Lucifergene: This pull request references ODC-7275 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Lucifergene Frontend test is failing due to lint error. |
Can we disable the |
/test e2e-gcp-console |
Its fixed now :) Tab-Topology.Red.Hat.OpenShift.7.mp4 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some smaller change ideas. Please take a look and let me know what you think:
// eslint-disable-next-line cypress/no-unnecessary-waiting | ||
cy.wait(5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this wait really needed? The next cypress condition also waits until the test-id is visible, or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the time required for the revision to appear seems more than the default timeout set. Therefore, need to explicitly put a wait :)
...ive-plugin/integration-tests/support/step-definitions/serverless/test-serverless-function.ts
Outdated
Show resolved
Hide resolved
frontend/packages/console-shared/src/components/editor/yaml-editor-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/integration-tests/support/constants/topology.ts
Outdated
Show resolved
Hide resolved
frontend/packages/topology/integration-tests/support/pages/topology/topology-actions-page.ts
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/test-function/ResponsePane.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/test-function/ResponsePane.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/test-function/TestFunction.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/test-function/TestFunction.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/test-function/TestFunctionModal.tsx
Outdated
Show resolved
Hide resolved
46eacae
to
99cc276
Compare
@Lucifergene: This pull request references ODC-7275 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on a cluster bot instance with different HTTP and cloudevents kn functions. We can fine-tune the modal and displayed data later if needed.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, Lucifergene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Propagate labels from the epic: /label docs-approved |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
@sanketpathak Let us know when we should address any e2e or test-related changes here. I'm mostly sure that we will have a follow up PR. Enjoy your pto 🌴 /label qe-approved |
/retest |
@Lucifergene: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes:
https://issues.redhat.com/browse/ODC-7275
Task List:
Screen shots / Gifs for design review:
Tab-Topology.OKD.11.mp4
E2E test coverage report:
Test setup:
https://github.com/openshift-dev-console/kn-func-typescript-cloudevents
Browser conformance: