Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] OCPBUGS-12476: Pipelines repository list and creation form doesn't show Tech Preview status #12763

Conversation

lokanandaprabhu
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/OCPBUGS-7031

Analysis / Root cause:
Tech preview label was not added

Solution Description:
Added Tech preview label for pipeline repository list and create page

Screen shots / Gifs for design review:
Screenshot 2023-04-24 at 12 51 12 PM

Screenshot 2023-04-24 at 12 51 22 PM

Unit test coverage report:
NA

Test setup:

  1. Install OpenShift Pipelines operator
  2. Navigate to Pipelines > Repository tab
  3. Select Create > Repository

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2023

@lokanandaprabhu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-7031: Pipelines repository list and creation form doesn't show Tech Preview status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2023
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-7031, which is invalid:

  • expected the bug to target the "4.12.z" version, but it targets "4.13.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-7031 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-7031

Analysis / Root cause:
Tech preview label was not added

Solution Description:
Added Tech preview label for pipeline repository list and create page

Screen shots / Gifs for design review:
Screenshot 2023-04-24 at 12 51 12 PM

Screenshot 2023-04-24 at 12 51 22 PM

Unit test coverage report:
NA

Test setup:

  1. Install OpenShift Pipelines operator
  2. Navigate to Pipelines > Repository tab
  3. Select Create > Repository

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Apr 24, 2023
@jerolimov
Copy link
Member

/retitle [release-4.12] OCPBUGS-12476: Pipelines repository list and creation form doesn't show Tech Preview status
/retest

@openshift-ci openshift-ci bot changed the title OCPBUGS-7031: Pipelines repository list and creation form doesn't show Tech Preview status [release-4.12] OCPBUGS-12476: Pipelines repository list and creation form doesn't show Tech Preview status Apr 24, 2023
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-12476, which is invalid:

  • expected Jira Issue OCPBUGS-12476 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-7031

Analysis / Root cause:
Tech preview label was not added

Solution Description:
Added Tech preview label for pipeline repository list and create page

Screen shots / Gifs for design review:
Screenshot 2023-04-24 at 12 51 12 PM

Screenshot 2023-04-24 at 12 51 22 PM

Unit test coverage report:
NA

Test setup:

  1. Install OpenShift Pipelines operator
  2. Navigate to Pipelines > Repository tab
  3. Select Create > Repository

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2023

@lokanandaprabhu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-12476: Pipelines repository list and creation form doesn't show Tech Preview status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2023
@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-12476, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-7031 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-7031 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lokanandaprabhu
Copy link
Contributor Author

Tested with cluster bot

/lgtm

Screen.Recording.2023-04-25.at.2.56.36.PM.mov

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

@lokanandaprabhu: you cannot LGTM your own PR.

In response to this:

Tested with cluster bot

/lgtm

Screen.Recording.2023-04-25.at.2.56.36.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 25, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2023
@hemantsaini-7
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2023

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 25f930d into openshift:release-4.12 Apr 29, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: Jira Issue OCPBUGS-12476: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12476 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-7031

Analysis / Root cause:
Tech preview label was not added

Solution Description:
Added Tech preview label for pipeline repository list and create page

Screen shots / Gifs for design review:
Screenshot 2023-04-24 at 12 51 12 PM

Screenshot 2023-04-24 at 12 51 22 PM

Unit test coverage report:
NA

Test setup:

  1. Install OpenShift Pipelines operator
  2. Navigate to Pipelines > Repository tab
  3. Select Create > Repository

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.12.0-202304290541.p0.g25f930d.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-04-29-195232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/pipelines Related to pipelines-plugin jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet