MGMT-14527: Add vSphere cluster field.

[rawagner]

Fix some additional minor issues & simplify code

[openshift-ci-robot]

@rawagner: This pull request references MGMT-14527 which is a valid jira issue.

In response to this:

Fix some additional minor issues & simplify code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@rawagner: This pull request references MGMT-14527 which is a valid jira issue.

In response to this:

Fix some additional minor issues & simplify code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rawagner]

/retest

[openshift-ci]

@rawagner: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mareklibra]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/vsphere-plugin/OWNERS [mareklibra,rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/vsphere-plugin/OWNERS [mareklibra,rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rawagner]

@opayne1 @RickJWagner @yanpzhan for the approvals.

[opayne1]

/label docs-approved

[RickJWagner]

Looks good.

/label px-approved

[yapei]

verified following

1. vCenter cluster field value is correctly populated
2. After updating vCenter cluster, new values can be successfully saved to failureDomains.topology.networks of infrastructure.config.openshift.io/cluster
3. pesudo translation is done for new added vCenter cluster filed and all other fields in the form

[yapei]

/label qe-approved

[rawagner]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@rawagner: #12806 failed to apply on top of branch "release-4.13":

Applying: Add vSphere cluster field. Fix some additional minor issues & simplify code
Using index info to reconstruct a base tree...
M	frontend/packages/vsphere-plugin/locales/en/vsphere-plugin.json
M	frontend/packages/vsphere-plugin/src/components/VSphereConnectionForm.tsx
M	frontend/packages/vsphere-plugin/src/components/VSphereConnectionModal.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/vsphere-plugin/src/components/VSphereConnectionModal.tsx
CONFLICT (content): Merge conflict in frontend/packages/vsphere-plugin/src/components/VSphereConnectionModal.tsx
Auto-merging frontend/packages/vsphere-plugin/src/components/VSphereConnectionForm.tsx
CONFLICT (content): Merge conflict in frontend/packages/vsphere-plugin/src/components/VSphereConnectionForm.tsx
Removing frontend/packages/vsphere-plugin/src/components/InProgress.tsx
Auto-merging frontend/packages/vsphere-plugin/locales/en/vsphere-plugin.json
CONFLICT (content): Merge conflict in frontend/packages/vsphere-plugin/locales/en/vsphere-plugin.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add vSphere cluster field. Fix some additional minor issues & simplify code
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.