OCPBUGS-6513: Fixed Edit Application form for Knative Services

[Lucifergene]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-6513

Analysis / Root cause:
The Edit form for Knative Services was broken. This was caused due to the presence of the health probes where it was not required. This caused the form to break.

Solution Description:
Removed the health probe details from the place it was causing errors while preserving it in another place.

Screenshots / Gifs for design review:

Tab-Topology.OKD.13.mp4

Unit test coverage report:

Not changed

Test setup:

1. Install Serverless Operator and Knative Serving instance
2. Paste the Following Yaml in the Import Yaml Editor:

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
  name: greeter
spec:
  template:
    spec:
      containers:
      - image: quay.io/rhdevelopers/knative-tutorial-greeter:quarkus
        livenessProbe:
          httpGet:
            path: /healthz
        readinessProbe:
          httpGet:
            path: /healthz

3. Go to the Topology View and right-click on the Service and click "Edit greeter".
4. Change the Runtime Icon in the Edit Application Form and Save.
5. Come to the Topology Page and see if the new runtime label has been added to the service.

NOTE: The Runtime Icon will not replace the Default Openshift Logo as currently the Runtime Label set in Knative Service is not auto-propagated to the Knative Revisions. To see the Runtime Icon in Knative Revision, you need to add the label to the Revision itself.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@Lucifergene: This pull request references Jira Issue OCPBUGS-6513, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-6513

Analysis / Root cause:
The Edit form for Knative Services was broken. This was caused due to the presence of the health probes where it was not required. This caused the form to break.

Solution Description:
Removed the health probe details from the place it was causing errors while preserving it in another place.

Screenshots / Gifs for design review:

Tab-Topology.OKD.13.mp4

Unit test coverage report:

Not changed

Test setup:

1. Install Serverless Operator and Knative Serving instance
2. Paste the Following Yaml in the Import Yaml Editor:

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
 name: greeter
spec:
 template:
   spec:
     containers:
     - image: quay.io/rhdevelopers/knative-tutorial-greeter:quarkus
       livenessProbe:
         httpGet:
           path: /healthz
       readinessProbe:
         httpGet:
           path: /healthz

3. Go to the Topology View and right-click on the Service and click "Edit greeter".
4. Change the Runtime Icon in the Edit Application Form and Save.
5. Come to the Topology Page and see if the new runtime label has been added to the service.

NOTE: The Runtime Icon will not replace the Default Openshift Logo as currently the Runtime Label set in Knative Service is not auto-propagated to the Knative Revisions. To see the Runtime Icon in Knative Revision, you need to add the label to the Revision itself.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Lucifergene]

/jira refresh

[openshift-ci-robot]

@Lucifergene: This pull request references Jira Issue OCPBUGS-6513, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vikram-raj]

I think it is not the right solution for this issue. If you notice we create another container using the image from the internal image registry and health checks get added to the newly created container. So, here can we prevent to creating a new container in the edit flow? @jerolimov @Lucifergene

In Create flow we do copy the external image to the internal registry and we use that to create a container but in the case of edit flow, we need to think about it.

One more thing that confuse the customer if we go with this fix. Before the edit there is no health check alert on the side panel of the KSVC but after the edit health alert start showing as there is no health check been omited from the first container. See the attached video

editKnServing.mov

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[Lucifergene]

/remove-lifecycle stale

[Lucifergene]

@vikram-raj I have resolved all the issues you had pointed in your comment now.
PTAL :)

[Lucifergene]

/retest

[vikram-raj]

Verified it and it works as expected.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/knative-plugin/OWNERS [vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Lucifergene]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@Lucifergene: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-6513, which is invalid:

• expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vikram-raj]

/jira refresh

[openshift-ci-robot]

@vikram-raj: This pull request references Jira Issue OCPBUGS-6513, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Lucifergene]

Attaching the label as it fixes a broken form.
/label acknowledge-critical-fixes-only

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 181742e and 2 for PR HEAD 659d951 in total

[openshift-ci]

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@Lucifergene: Jira Issue OCPBUGS-6513: All pull requests linked via external trackers have merged:

• openshift/console#12832

Jira Issue OCPBUGS-6513 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-6513

Analysis / Root cause:
The Edit form for Knative Services was broken. This was caused due to the presence of the health probes where it was not required. This caused the form to break.

Solution Description:
Removed the health probe details from the place it was causing errors while preserving it in another place.

Screenshots / Gifs for design review:

Tab-Topology.OKD.13.mp4

Unit test coverage report:

Not changed

Test setup:

1. Install Serverless Operator and Knative Serving instance
2. Paste the Following Yaml in the Import Yaml Editor:

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
 name: greeter
spec:
 template:
   spec:
     containers:
     - image: quay.io/rhdevelopers/knative-tutorial-greeter:quarkus
       livenessProbe:
         httpGet:
           path: /healthz
       readinessProbe:
         httpGet:
           path: /healthz

3. Go to the Topology View and right-click on the Service and click "Edit greeter".
4. Change the Runtime Icon in the Edit Application Form and Save.
5. Come to the Topology Page and see if the new runtime label has been added to the service.

NOTE: The Runtime Icon will not replace the Default Openshift Logo as currently the Runtime Label set in Knative Service is not auto-propagated to the Knative Revisions. To see the Runtime Icon in Knative Revision, you need to add the label to the Revision itself.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@Lucifergene: new pull request created: #13147

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-09-14-125123

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-09-15-090049

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-09-16-110027

[Lucifergene]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@Lucifergene: new pull request created: #13279

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.