OCPBUGS-14149: account for single object in status.conditions instead… #12866

rhamilto · 2023-05-30T17:50:04Z

… of an array of objects

Kepler operands return a single object for status.conditions [1] instead of an array of objects. This fix accounts for this unexpected behavior from the operand.

[1]

apiVersion: kepler.system.sustainable.computing.io/v1alpha1
kind: Kepler
metadata:
  creationTimestamp: '2023-05-30T18:04:03Z'
  generation: 1
  labels:
    app.kubernetes.io/created-by: kepler-operator
    app.kubernetes.io/instance: kepler
    app.kubernetes.io/managed-by: kustomize
    app.kubernetes.io/name: kepler
    app.kubernetes.io/part-of: kepler-operator
  managedFields:
    - apiVersion: kepler.system.sustainable.computing.io/v1alpha1
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:labels':
            .: {}
            'f:app.kubernetes.io/created-by': {}
            'f:app.kubernetes.io/instance': {}
            'f:app.kubernetes.io/managed-by': {}
            'f:app.kubernetes.io/name': {}
            'f:app.kubernetes.io/part-of': {}
        'f:spec':
          .: {}
          'f:collector':
            .: {}
            'f:collectorPort': {}
            'f:image': {}
      manager: Mozilla
      operation: Update
      time: '2023-05-30T18:04:03Z'
    - apiVersion: kepler.system.sustainable.computing.io/v1alpha1
      fieldsType: FieldsV1
      fieldsV1:
        'f:status':
          .: {}
          'f:conditions':
            .: {}
            'f:lastTransitionTime': {}
            'f:message': {}
            'f:reason': {}
            'f:status': {}
            'f:type': {}
      manager: manager
      operation: Update
      subresource: status
      time: '2023-05-30T18:04:05Z'
  name: kepler
  namespace: openshift-operators
  resourceVersion: '10230'
  uid: 396ce277-db6c-4800-b87d-e8e278c6b68b
spec:
  collector:
    collectorPort: 9103
    image: 'quay.io/sustainable_computing_io/kepler:release-0.4'
status:
  conditions:
    lastTransitionTime: '2023-05-30T18:04:03Z'
    message: Reconcile complete
    reason: ReconcileComplete
    status: 'True'
    type: Reconciled

openshift-ci-robot · 2023-05-30T17:50:09Z

@rhamilto: This pull request references Jira Issue OCPBUGS-14149, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

… of an array of objects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-05-30T18:04:49Z

@rhamilto: This pull request references Jira Issue OCPBUGS-14149, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

… of an array of objects

Kepler operands return a single object for status.conditions [1] instead of an array of objects. This fix accounts for this unexpected behavior from the operand.

[1]

apiVersion: kepler.system.sustainable.computing.io/v1alpha1
kind: Kepler
metadata:
 creationTimestamp: '2023-05-30T18:04:03Z'
 generation: 1
 labels:
   app.kubernetes.io/created-by: kepler-operator
   app.kubernetes.io/instance: kepler
   app.kubernetes.io/managed-by: kustomize
   app.kubernetes.io/name: kepler
   app.kubernetes.io/part-of: kepler-operator
 managedFields:
   - apiVersion: kepler.system.sustainable.computing.io/v1alpha1
     fieldsType: FieldsV1
     fieldsV1:
       'f:metadata':
         'f:labels':
           .: {}
           'f:app.kubernetes.io/created-by': {}
           'f:app.kubernetes.io/instance': {}
           'f:app.kubernetes.io/managed-by': {}
           'f:app.kubernetes.io/name': {}
           'f:app.kubernetes.io/part-of': {}
       'f:spec':
         .: {}
         'f:collector':
           .: {}
           'f:collectorPort': {}
           'f:image': {}
     manager: Mozilla
     operation: Update
     time: '2023-05-30T18:04:03Z'
   - apiVersion: kepler.system.sustainable.computing.io/v1alpha1
     fieldsType: FieldsV1
     fieldsV1:
       'f:status':
         .: {}
         'f:conditions':
           .: {}
           'f:lastTransitionTime': {}
           'f:message': {}
           'f:reason': {}
           'f:status': {}
           'f:type': {}
     manager: manager
     operation: Update
     subresource: status
     time: '2023-05-30T18:04:05Z'
 name: kepler
 namespace: openshift-operators
 resourceVersion: '10230'
 uid: 396ce277-db6c-4800-b87d-e8e278c6b68b
spec:
 collector:
   collectorPort: 9103
   image: 'quay.io/sustainable_computing_io/kepler:release-0.4'
status:
 conditions:
   lastTransitionTime: '2023-05-30T18:04:03Z'
   message: Reconcile complete
   reason: ReconcileComplete
   status: 'True'
   type: Reconciled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2023-05-30T18:07:08Z

/jira refresh

openshift-ci-robot · 2023-05-30T18:07:14Z

@rhamilto: This pull request references Jira Issue OCPBUGS-14149, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stleerh · 2023-05-30T19:20:43Z

frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx

-  const trueConditions = conditions?.filter((c: K8sResourceCondition) => c.status === 'True');
+  const conditionsIsObject =
+    typeof conditions === 'object' && !Array.isArray(conditions) && conditions !== null;
+  const conditionsArray = conditionsIsObject ? [conditions] : conditions;


The conditionsArray name can be misleading because it could be null (or even a string if conditions can be a string or other non-object type).

Good point, @stleerh. How do you feel about formattedConditions instead? Still not great...

… of an array of objects

openshift-ci · 2023-05-30T21:06:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, stleerh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/operator-lifecycle-manager/OWNERS~~ [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-05-31T00:56:36Z

/retest-required

Remaining retests: 0 against base HEAD b454f29 and 2 for PR HEAD 9c03b0f in total

rhamilto · 2023-05-31T12:46:39Z

/retest

rhamilto · 2023-05-31T16:38:07Z

/retest

rhamilto · 2023-05-31T22:11:51Z

/retest

openshift-ci-robot · 2023-06-01T03:29:26Z

/retest-required

Remaining retests: 0 against base HEAD c85d678 and 1 for PR HEAD 9c03b0f in total

openshift-ci · 2023-06-01T08:40:16Z

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-06-01T08:42:48Z

@rhamilto: Jira Issue OCPBUGS-14149: All pull requests linked via external trackers have merged:

openshift/console#12866

Jira Issue OCPBUGS-14149 has been moved to the MODIFIED state.

In response to this:

… of an array of objects

Kepler operands return a single object for status.conditions [1] instead of an array of objects. This fix accounts for this unexpected behavior from the operand.

[1]

apiVersion: kepler.system.sustainable.computing.io/v1alpha1
kind: Kepler
metadata:
 creationTimestamp: '2023-05-30T18:04:03Z'
 generation: 1
 labels:
   app.kubernetes.io/created-by: kepler-operator
   app.kubernetes.io/instance: kepler
   app.kubernetes.io/managed-by: kustomize
   app.kubernetes.io/name: kepler
   app.kubernetes.io/part-of: kepler-operator
 managedFields:
   - apiVersion: kepler.system.sustainable.computing.io/v1alpha1
     fieldsType: FieldsV1
     fieldsV1:
       'f:metadata':
         'f:labels':
           .: {}
           'f:app.kubernetes.io/created-by': {}
           'f:app.kubernetes.io/instance': {}
           'f:app.kubernetes.io/managed-by': {}
           'f:app.kubernetes.io/name': {}
           'f:app.kubernetes.io/part-of': {}
       'f:spec':
         .: {}
         'f:collector':
           .: {}
           'f:collectorPort': {}
           'f:image': {}
     manager: Mozilla
     operation: Update
     time: '2023-05-30T18:04:03Z'
   - apiVersion: kepler.system.sustainable.computing.io/v1alpha1
     fieldsType: FieldsV1
     fieldsV1:
       'f:status':
         .: {}
         'f:conditions':
           .: {}
           'f:lastTransitionTime': {}
           'f:message': {}
           'f:reason': {}
           'f:status': {}
           'f:type': {}
     manager: manager
     operation: Update
     subresource: status
     time: '2023-05-30T18:04:05Z'
 name: kepler
 namespace: openshift-operators
 resourceVersion: '10230'
 uid: 396ce277-db6c-4800-b87d-e8e278c6b68b
spec:
 collector:
   collectorPort: 9103
   image: 'quay.io/sustainable_computing_io/kepler:release-0.4'
status:
 conditions:
   lastTransitionTime: '2023-05-30T18:04:03Z'
   message: Reconcile complete
   reason: ReconcileComplete
   status: 'True'
   type: Reconciled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

husky-parul · 2023-06-01T13:46:37Z

@rhamilto is there a way to test the merged changes. For e.g. could ask cluster-bot to launch a cluster by sourcing from a branch but I am not sure if there is a way to do it for opeshift/console?

rhamilto · 2023-06-01T13:51:51Z

/cherry-pick release-4.13

openshift-cherrypick-robot · 2023-06-01T13:52:34Z

@rhamilto: new pull request created: #12875

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2023-06-01T13:53:06Z

@rhamilto is there a way to test the merged changes. For e.g. could ask cluster-bot to launch a cluster by sourcing from a branch but I am not sure if there is a way to do it for opeshift/console?

Since this fix has merged, cluster bot should automatically include it in any default clusters it creates.

husky-parul · 2023-06-01T13:59:15Z

I've just launched a cluster but I still the error

OpenShift version: 4.14.0-0.nightly-2023-05-31-080250
Kubernetes version: v1.27.2+15f19ea

rhamilto · 2023-06-01T14:03:17Z

I've just launched a cluster but I still the error
OpenShift version: 4.14.0-0.nightly-2023-05-31-080250
Kubernetes version: v1.27.2+15f19ea

I am guessing the fix is not available in the latest build available to clusterbot. I am not sure on the timing of such.

rhamilto · 2023-06-01T14:05:04Z

You can optionally build and run console locally by following https://github.com/openshift/console#quickstart.

husky-parul · 2023-06-01T14:06:14Z

Thanks I will TAL

spadgett · 2023-06-01T20:23:30Z

OpenShift version: 4.14.0-0.nightly-2023-05-31-080250
Kubernetes version: v1.27.2+15f19ea

The fix isn't in a nightly yet. You can see the nightly change logs here: https://openshift-release.apps.ci.l2s4.p1.openshiftapps.com/#4.14.0-0.nightly

openshift-ci bot requested review from spadgett and TheRealJon May 30, 2023 17:51

openshift-ci bot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 30, 2023

rhamilto assigned TheRealJon May 30, 2023

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 30, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 30, 2023

openshift-ci bot requested a review from yapei May 30, 2023 18:07

stleerh reviewed May 30, 2023

View reviewed changes

OCPBUGS-14149: account for single object in status.conditions instead…

9c03b0f

… of an array of objects

rhamilto force-pushed the OCPBUGS-14149 branch from c78e9f6 to 9c03b0f Compare May 30, 2023 20:44

openshift-ci bot assigned stleerh May 30, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023

openshift-merge-robot merged commit 541738b into openshift:master Jun 1, 2023
6 checks passed

rhamilto deleted the OCPBUGS-14149 branch June 1, 2023 12:24

openshift-cherrypick-robot mentioned this pull request Jun 1, 2023

[release-4.13] OCPBUGS-14426: account for single object in status.conditions instead… #12875

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-14149: account for single object in status.conditions instead… #12866

OCPBUGS-14149: account for single object in status.conditions instead… #12866

rhamilto commented May 30, 2023 •

edited

openshift-ci-robot commented May 30, 2023

openshift-ci-robot commented May 30, 2023

rhamilto commented May 30, 2023

openshift-ci-robot commented May 30, 2023

stleerh May 30, 2023

rhamilto May 30, 2023

stleerh May 30, 2023

openshift-ci bot commented May 30, 2023

openshift-ci-robot commented May 31, 2023

rhamilto commented May 31, 2023

rhamilto commented May 31, 2023

rhamilto commented May 31, 2023

openshift-ci-robot commented Jun 1, 2023

openshift-ci bot commented Jun 1, 2023

openshift-ci-robot commented Jun 1, 2023

husky-parul commented Jun 1, 2023

rhamilto commented Jun 1, 2023

openshift-cherrypick-robot commented Jun 1, 2023

rhamilto commented Jun 1, 2023

husky-parul commented Jun 1, 2023 •

edited

rhamilto commented Jun 1, 2023

rhamilto commented Jun 1, 2023

husky-parul commented Jun 1, 2023

spadgett commented Jun 1, 2023

OCPBUGS-14149: account for single object in status.conditions instead… #12866

OCPBUGS-14149: account for single object in status.conditions instead… #12866

Conversation

rhamilto commented May 30, 2023 • edited

openshift-ci-robot commented May 30, 2023

openshift-ci-robot commented May 30, 2023

rhamilto commented May 30, 2023

openshift-ci-robot commented May 30, 2023

stleerh May 30, 2023

Choose a reason for hiding this comment

rhamilto May 30, 2023

Choose a reason for hiding this comment

stleerh May 30, 2023

Choose a reason for hiding this comment

openshift-ci bot commented May 30, 2023

openshift-ci-robot commented May 31, 2023

rhamilto commented May 31, 2023

rhamilto commented May 31, 2023

rhamilto commented May 31, 2023

openshift-ci-robot commented Jun 1, 2023

openshift-ci bot commented Jun 1, 2023

openshift-ci-robot commented Jun 1, 2023

husky-parul commented Jun 1, 2023

rhamilto commented Jun 1, 2023

openshift-cherrypick-robot commented Jun 1, 2023

rhamilto commented Jun 1, 2023

husky-parul commented Jun 1, 2023 • edited

rhamilto commented Jun 1, 2023

rhamilto commented Jun 1, 2023

husky-parul commented Jun 1, 2023

spadgett commented Jun 1, 2023

rhamilto commented May 30, 2023 •

edited

husky-parul commented Jun 1, 2023 •

edited