ODC-7337: Skip wait for authentication operator to start progressing when the secret already exists #12884
Conversation
sanketpathak
force-pushed
the
prow-change-topology-periodic-test
branch
from
1e4968a
to
a6da146
Compare
|
/retest |
|
/test e2e-gcp-console |
test-prow-e2e.sh
Outdated
| set -x | ||
| # Skip wait for authentication operator to start Progressing when the Secret already exists. | ||
| # And ignore any kind of errors when the Secret doesn't exist. | ||
| set +e |
There was a problem hiding this comment.
Maybe just use --ignore-not-found instead of set +e? That would be better so that we still fail on other errors.
There was a problem hiding this comment.
Thanks @spadgett, updated the pr
test-prow-e2e.sh
Outdated
| # Skip wait for authentication operator to start Progressing when the Secret already exists. | ||
| # And ignore any kind of errors when the Secret doesn't exist. | ||
| set +e | ||
| htpasswdSecretName=$(oc get secret -n openshift-config htpass-secret -o name 2> /dev/null) |
There was a problem hiding this comment.
nitpick: shell scripts typically use snake case for var names like htpasswd_secret_name
There was a problem hiding this comment.
Thanks @spadgett, updated the pr
|
/retitle ODC-7337: Skip wait for authentication operator to start progressing when the secret already exists |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@sanketpathak: This pull request references ODC-7337 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ecret already exists
sanketpathak
force-pushed
the
prow-change-topology-periodic-test
branch
from
a6da146
to
bc79776
Compare
|
@sanketpathak: This pull request references ODC-7337 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sanketpathak: This pull request references ODC-7337 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sanketpathak: This pull request references ODC-7337 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, sanketpathak, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Chore change that makes the /label docs-approved |
openshift-ci
bot
added
docs-approved
|
@sanketpathak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue: https://issues.redhat.com/browse/ODC-7337
Description: For periodic jobs, our tests will append to existing console tests but because the value of
waitForAuthOperatorProgressingchanges from true to false at the start of console tests and with the same procedure our tests keep on waiting to fetch its value as true which never happens and tests do not start