Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14915: Remove entries from the menu that are now added by monitoring-plugin #12893

Merged

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jun 13, 2023

Based on @jgbernalp's #12583 PR

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 13, 2023
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Jira Issue OCPBUGS-14915, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from spadgett and zherman0 June 13, 2023 14:43
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 13, 2023
@kyoto
Copy link
Member Author

kyoto commented Jun 13, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 13, 2023
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Jira Issue OCPBUGS-14915, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei June 13, 2023 14:44
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Jira Issue OCPBUGS-14915, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Based on @jgbernalp's #12583 PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto kyoto changed the title [WIP] OCPBUGS-14915: Remove entries from the menu that are now added by monitoring-plugin OCPBUGS-14915: Remove entries from the menu that are now added by monitoring-plugin Jun 14, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2023
@kyoto kyoto force-pushed the monitoring-remove-nav-entries branch from 1c67f55 to 7cc6f55 Compare June 14, 2023 07:39
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jun 14, 2023
@kyoto kyoto changed the title OCPBUGS-14915: Remove entries from the menu that are now added by monitoring-plugin OCPBUGS-14915: Fix routes for Alertmanager config and remove entries from the menu that are now added by monitoring-plugin Jun 15, 2023
@kyoto kyoto changed the title OCPBUGS-14915: Fix routes for Alertmanager config and remove entries from the menu that are now added by monitoring-plugin OCPBUGS-14964, OCPBUGS-14915: Fix routes for Alertmanager config and remove entries from the menu that are now added by monitoring-plugin Jun 15, 2023
@kyoto kyoto changed the title OCPBUGS-14964, OCPBUGS-14915: Fix routes for Alertmanager config and remove entries from the menu that are now added by monitoring-plugin [WIP] OCPBUGS-14964, OCPBUGS-14915: Fix routes for Alertmanager config and remove entries from the menu that are now added by monitoring-plugin Jun 16, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2023
@kyoto kyoto force-pushed the monitoring-remove-nav-entries branch from 2d65a30 to 7cc6f55 Compare June 19, 2023 02:10
@kyoto kyoto changed the title [WIP] OCPBUGS-14964, OCPBUGS-14915: Fix routes for Alertmanager config and remove entries from the menu that are now added by monitoring-plugin OCPBUGS-14915: Remove entries from the menu that are now added by monitoring-plugin Jun 19, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2023
@kyoto
Copy link
Member Author

kyoto commented Jun 19, 2023

/retest

@jgbernalp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, kyoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ff3493d and 2 for PR HEAD 7cc6f55 in total

@openshift-merge-robot openshift-merge-robot merged commit 9d4a50b into openshift:master Jun 19, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@kyoto: Jira Issue OCPBUGS-14915: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14915 has been moved to the MODIFIED state.

In response to this:

Based on @jgbernalp's #12583 PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

@kyoto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants