Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-15099: visiting Configurations page returns error Cannot read… #12906

Merged
merged 1 commit into from Jun 28, 2023
Merged

[release-4.12] OCPBUGS-15099: visiting Configurations page returns error Cannot read… #12906

merged 1 commit into from Jun 28, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #12897

/assign tvu20

@tvu20
OCPBUGS-14668: visiting Configurations page returns error Cannot read…
2598138 
… properties of undefined

Fixes https://issues.redhat.com/browse/OCPBUGS-14668

Visitng Configurations page no longer returns described error.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-14943 has been cloned as Jira Issue OCPBUGS-15099. Will retitle bug to link to clone.
/retitle [release-4.12] OCPBUGS-15099: visiting Configurations page returns error Cannot read…

In response to this:

This is an automated cherry-pick of #12897

/assign tvu20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-14943: visiting Configurations page returns error Cannot read… [release-4.12] OCPBUGS-15099: visiting Configurations page returns error Cannot read… Jun 16, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 16, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15099, which is invalid:

  • expected dependent Jira Issue OCPBUGS-14943 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #12897

/assign tvu20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jun 16, 2023
@tvu20
Copy link
Contributor

tvu20 commented Jun 16, 2023

/retest

jhadvig
jhadvig approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 20, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@tvu20
Copy link
Contributor

tvu20 commented Jun 20, 2023

/retest

3 similar comments
@tvu20
Copy link
Contributor

tvu20 commented Jun 20, 2023

/retest

@tvu20
Copy link
Contributor

tvu20 commented Jun 20, 2023

/retest

@tvu20
Copy link
Contributor

tvu20 commented Jun 21, 2023

/retest

@tvu20
Copy link
Contributor

tvu20 commented Jun 21, 2023

/retest-required

@jhadvig
Copy link
Member

jhadvig commented Jun 22, 2023

/retest

@tvu20
Copy link
Contributor

tvu20 commented Jun 22, 2023

/retest

1 similar comment
@tvu20
Copy link
Contributor

tvu20 commented Jun 23, 2023

/retest

@yapei
Copy link
Contributor

yapei commented Jun 27, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 27, 2023
@openshift-ci-robot
Copy link
Contributor

@yapei: This pull request references Jira Issue OCPBUGS-15099, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-14943 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-14943 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei June 27, 2023 03:00
@yapei
Copy link
Contributor

yapei commented Jun 27, 2023

verified the fix is working as expected on 4.12.z
/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jun 27, 2023
@tvu20
Copy link
Contributor

tvu20 commented Jun 27, 2023

/retest

1 similar comment
@jerolimov
Copy link
Member

/retest

@tvu20
Copy link
Contributor

tvu20 commented Jun 28, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot, tvu20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tvu20
Copy link
Contributor

tvu20 commented Jun 28, 2023

/cherry-pick release-4.11

@openshift-cherrypick-robot
Copy link
Author

@tvu20: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 97ef94a into openshift:release-4.12 Jun 28, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-15099: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15099 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #12897

/assign tvu20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Author

@tvu20: new pull request created: #12953

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@spadgett spadgett Awaiting requested review from spadgett

@yapei yapei Awaiting requested review from yapei

Assignees

@gouyang gouyang

@jrichter1 jrichter1

@ebenahar ebenahar

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@juzhao juzhao

@tvu20 tvu20

@The-Anton The-Anton

@lihongyan1 lihongyan1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet