Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7325: Improve BuildConfig and Shipwright Build list pages #12910

Merged
merged 5 commits into from Jul 4, 2023
Merged

ODC-7325: Improve BuildConfig and Shipwright Build list pages #12910

merged 5 commits into from Jul 4, 2023

Conversation

vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Jun 17, 2023 •
edited

Story: https://issues.redhat.com/browse/ODC-7325

Descriptions:

  1. BuildConfig list page
    • should have a filter similar to the Build list page (New, Pending, Running ....)
    • all columns should be sortable
    • duration column should show the time until "now" if the latest run is running
    • should have an action "Start last run" if there is a last run (see Build "Rebuild" action)
  2. Build list page
    • all columns should be sortable
    • should show a duration as well
    • should have an action "Start last run" if there is a last run (see Build "Rerun" action)
  3. Shipwright Build list page
    • should have a filter similar to the Shipwright BuildRun list page (New, Pending, Running ....)
    • Rename column title "Age" to "Started" (similar to Pipeline Run lists)

GIF:

BuildAndShiwrightPageImprovement.mov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 17, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 17, 2023 •
edited by openshift-ci bot

@vikram-raj: This pull request references ODC-7325 which is a valid jira issue.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7325

Descriptions:

  1. BuildConfig list page
    • should have a filter similar to the Build list page (New, Pending, Running ....)
    • all columns should be sortable
    • duration column should show the time until "now" if the latest run is running - TODO
    • should have an action "Start last run" if there is a last run (see Build "Rebuild" action)
  2. Build list page
    • all columns should be sortable
    • should show a duration as well
    • should have an action "Start last run" if there is a last run (see Build "Rerun" action)
  3. Shipwright Build list page
    • should have a filter similar to the Shipwright BuildRun list page (New, Pending, Running ....) - TODO
    • Rename column title "Age" to "Started" (similar to Pipeline Run lists)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jhadvig and sahil143 June 17, 2023 00:17
@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 17, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 17, 2023 •
edited by openshift-ci bot

@vikram-raj: This pull request references ODC-7325 which is a valid jira issue.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7325

Descriptions:

  1. BuildConfig list page
    • should have a filter similar to the Build list page (New, Pending, Running ....)
    • all columns should be sortable
    • duration column should show the time until "now" if the latest run is running - TODO
    • should have an action "Start last run" if there is a last run (see Build "Rebuild" action)
  2. Build list page
    • all columns should be sortable
    • should show a duration as well
    • should have an action "Start last run" if there is a last run (see Build "Rerun" action)
  3. Shipwright Build list page
    • should have a filter similar to the Shipwright BuildRun list page (New, Pending, Running ....) - TODO
    • Rename column title "Age" to "Started" (similar to Pipeline Run lists)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

/uncc @sahil143
/cc @jerolimov

@openshift-ci openshift-ci bot requested review from jerolimov and removed request for sahil143 June 17, 2023 00:18
@jerolimov
Copy link
Member

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 19, 2023 •
edited by openshift-ci bot

@vikram-raj: This pull request references ODC-7325 which is a valid jira issue.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7325

Descriptions:

  1. BuildConfig list page
    • should have a filter similar to the Build list page (New, Pending, Running ....)
    • all columns should be sortable
    • duration column should show the time until "now" if the latest run is running - TODO
    • should have an action "Start last run" if there is a last run (see Build "Rebuild" action)
  2. Build list page
    • all columns should be sortable
    • should show a duration as well
    • should have an action "Start last run" if there is a last run (see Build "Rerun" action)
  3. Shipwright Build list page
    • should have a filter similar to the Shipwright BuildRun list page (New, Pending, Running ....)
    • Rename column title "Age" to "Started" (similar to Pipeline Run lists)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 19, 2023 •
edited by openshift-ci bot

@vikram-raj: This pull request references ODC-7325 which is a valid jira issue.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7325

Descriptions:

  1. BuildConfig list page
    • should have a filter similar to the Build list page (New, Pending, Running ....)
    • all columns should be sortable
    • duration column should show the time until "now" if the latest run is running
    • should have an action "Start last run" if there is a last run (see Build "Rebuild" action)
  2. Build list page
    • all columns should be sortable
    • should show a duration as well
    • should have an action "Start last run" if there is a last run (see Build "Rerun" action)
  3. Shipwright Build list page
    • should have a filter similar to the Shipwright BuildRun list page (New, Pending, Running ....)
    • Rename column title "Age" to "Started" (similar to Pipeline Run lists)

GIF:

BuildAndShiwrightPageImprovement.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerolimov
jerolimov suggested changes Jun 19, 2023
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting and status filters work fine. I found some small think to fine-tune. :)

In the Admin perspective, we also show the list of (OpenShift) Builds. Can we add a row for the Builds as well to show the Started and Duration columns there?

frontend/packages/shipwright-plugin/src/components/build-list/BuildTable.tsx Outdated Show resolved Hide resolved
frontend/packages/shipwright-plugin/src/actions/useBuildActions.ts Outdated Show resolved Hide resolved
frontend/public/components/build-config.tsx Outdated Show resolved Hide resolved
frontend/public/components/build-config.tsx Outdated Show resolved Hide resolved
frontend/public/components/build-config.tsx Outdated Show resolved Hide resolved
frontend/public/components/build-config.tsx Show resolved Hide resolved
frontend/public/components/build-config.tsx Outdated Show resolved Hide resolved
frontend/packages/shipwright-plugin/src/components/build-list/BuildTable.tsx Show resolved Hide resolved
frontend/public/components/build-config.tsx
const menuActions = [
startBuildAction,
startLastBuildAction,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not see this action in my BuildConfig action menu 🤔

image

frontend/public/components/build-config.tsx Outdated Show resolved Hide resolved
@vikram-raj vikram-raj force-pushed the odc-7325 branch 2 times, most recently from 8eb2c66 to 03daff9 Compare June 20, 2023 12:43
@vikram-raj
Copy link
Member Author

@jerolimov addressed all the review comments PTAL again. Thanks.

@vikram-raj
Copy link
Member Author

/retest

jerolimov
jerolimov suggested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested everything and it looks really good. Just that I don't think we need a Created and Started column here:

image

frontend/public/components/build.tsx Outdated Show resolved Hide resolved
@vikram-raj
add Start time and Duration columnn in Admin perspectivr builds list …
652ec23 
…page and show duration on details page whie build is running
jerolimov
jerolimov approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 👍

/lgtm
/approve

@jerolimov
Copy link
Member

Propagate from the epic

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 26, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerolimov jerolimov mentioned this pull request Jul 3, 2023
Closed
@sanketpathak
Copy link
Contributor

Verified on the cluster using cluster-bot with kubeadmin and non-admin user

Screen.Recording.2023-07-03.at.3.24.05.PM.mov

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 3, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 12b4f6e and 2 for PR HEAD 652ec23 in total

@jerolimov
Copy link
Member

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c5c7900 and 1 for PR HEAD 652ec23 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 558d70c into openshift:master Jul 4, 2023
6 checks passed
@vikram-raj vikram-raj deleted the odc-7325 branch July 4, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@jerolimov jerolimov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vikram-raj @openshift-ci-robot @jerolimov @sanketpathak @openshift-merge-robot