Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-11464: Availability requirement update is initially disabled … #12918

Merged
merged 1 commit into from Jun 21, 2023

Conversation

tvu20
Copy link
Contributor

@tvu20 tvu20 commented Jun 20, 2023

…on Edit PodDisruptionBudget page

Fixes: https://issues.redhat.com/browse/OCPBUGS-11464

When editing PDB, form loaded with current value and user can edit values by default

…on Edit PodDisruptionBudget page

Fixes: https://issues.redhat.com/browse/OCPBUGS-11464

When editing PDB, form loaded with current value and user can edit values by default
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 20, 2023
@openshift-ci-robot
Copy link
Contributor

@tvu20: This pull request references Jira Issue OCPBUGS-11464, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…on Edit PodDisruptionBudget page

Fixes: https://issues.redhat.com/browse/OCPBUGS-11464

When editing PDB, form loaded with current value and user can edit values by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jcaianirh and kyoto June 20, 2023 21:33
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jun 20, 2023
@tvu20
Copy link
Contributor Author

tvu20 commented Jun 20, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 20, 2023
@openshift-ci-robot
Copy link
Contributor

@tvu20: This pull request references Jira Issue OCPBUGS-11464, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei June 20, 2023 21:33
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, tvu20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dee0eb5 and 2 for PR HEAD 1a81822 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@tvu20: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 36cd213 into openshift:master Jun 21, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@tvu20: Jira Issue OCPBUGS-11464: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11464 has been moved to the MODIFIED state.

In response to this:

…on Edit PodDisruptionBudget page

Fixes: https://issues.redhat.com/browse/OCPBUGS-11464

When editing PDB, form loaded with current value and user can edit values by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants