Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OU-198: Revert "Disable broken monitoring-tests" #12943

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jun 27, 2023

This reverts commit 743df83 (PR #12902).

These test failures were fixed by openshift/monitoring-plugin#48

@openshift-ci openshift-ci bot requested review from rhamilto and zherman0 June 27, 2023 07:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@kyoto
Copy link
Member Author

kyoto commented Jun 27, 2023

This is just a change to the tests. There are no user visible changes.

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jun 27, 2023
@kyoto
Copy link
Member Author

kyoto commented Jun 28, 2023

/assign @rhamilto

@kyoto kyoto changed the title Revert "Disable broken monitoring-tests" OCPBUGS-14964: Revert "Disable broken monitoring-tests" Jun 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 28, 2023
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Jira Issue OCPBUGS-14964, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This reverts commit 743df83 (PR #12902).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto kyoto changed the title OCPBUGS-14964: Revert "Disable broken monitoring-tests" OU-198: Revert "Disable broken monitoring-tests" Jun 28, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 28, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 28, 2023

@kyoto: This pull request references OU-198 which is a valid jira issue.

In response to this:

This reverts commit 743df83 (PR #12902).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 29, 2023

@kyoto: This pull request references OU-198 which is a valid jira issue.

In response to this:

This reverts commit 743df83 (PR #12902).

These test failures were fixed by openshift/monitoring-plugin#48

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juzhao
Copy link

juzhao commented Jun 29, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2023

@kyoto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5e15ef4 into openshift:master Jun 29, 2023
6 checks passed
@kyoto kyoto deleted the revert-disable-broken-alertmanager-tests branch June 29, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants