Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-15021: Use FLAGS.CAN_GET_NS to decide whether to show Route details > Metrics tab #12944

Merged
merged 1 commit into from Jul 12, 2023
Merged

OCPBUGS-15021: Use FLAGS.CAN_GET_NS to decide whether to show Route details > Metrics tab #12944

merged 1 commit into from Jul 12, 2023

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jun 27, 2023 •
edited

This makes the permissions check consistent with the check done by the Metrics page itself.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2023
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 27, 2023
@kyoto
Hide Route details > Metrics tab if FLAGS.CAN_GET_NS is not set
684cf66 
This makes the permissions check consistent with the check done by the
Metrics page itself.
@kyoto kyoto changed the title [WIP] Use usePrometheusGate hook for Route > Metrics page [WIP] Use FLAGS.CAN_GET_NS to decide whether to show Route details > Metrics tab Jun 28, 2023
@kyoto kyoto changed the title [WIP] Use FLAGS.CAN_GET_NS to decide whether to show Route details > Metrics tab [WIP] OCPBUGS-15021: Use FLAGS.CAN_GET_NS to decide whether to show Route details > Metrics tab Jun 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 28, 2023
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Jira Issue OCPBUGS-15021, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto
Copy link
Member Author

kyoto commented Jun 28, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 28, 2023
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Jira Issue OCPBUGS-15021, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei June 28, 2023 06:22
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Jira Issue OCPBUGS-15021, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

This makes the permissions check consistent with the check done by the Metrics page itself.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto kyoto changed the title [WIP] OCPBUGS-15021: Use FLAGS.CAN_GET_NS to decide whether to show Route details > Metrics tab OCPBUGS-15021: Use FLAGS.CAN_GET_NS to decide whether to show Route details > Metrics tab Jun 28, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

@kyoto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyoto
Copy link
Member Author

kyoto commented Jul 4, 2023

@spadgett Could you please take a look?
/assign @spadgett

jhadvig
jhadvig approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, kyoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 89bfa53 into openshift:master Jul 12, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@kyoto: Jira Issue OCPBUGS-15021: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15021 has been moved to the MODIFIED state.

In response to this:

This makes the permissions check consistent with the check done by the Metrics page itself.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto kyoto deleted the fix-route-metrics-check branch July 13, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@rhamilto rhamilto Awaiting requested review from rhamilto

@yapei yapei Awaiting requested review from yapei

Assignees

@spadgett spadgett

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyoto @openshift-ci-robot @jhadvig @spadgett @openshift-merge-robot