Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-3680: Convert row-filter.jsx from class component to function… #12957

Merged
merged 1 commit into from Jul 14, 2023

Conversation

tvu20
Copy link
Contributor

@tvu20 tvu20 commented Jun 29, 2023

…al component

Removes CheckBoxes_ component from row-filter.jsx, since it is no longer used in the codebase.

…al component

Removes CheckBoxes_ component from row-filter.jsx, since it is no longer used in the codebase.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 29, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 29, 2023

@tvu20: This pull request references CONSOLE-3680 which is a valid jira issue.

In response to this:

…al component

Removes CheckBoxes_ component from row-filter.jsx, since it is no longer used in the codebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jun 29, 2023
@tvu20
Copy link
Contributor Author

tvu20 commented Jun 30, 2023

/retest

@jhadvig
Copy link
Member

jhadvig commented Jul 12, 2023

/lgtm
/approve

This is internal Console code cleanup, no impact on end users or docs.

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Jul 12, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, tvu20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0a320fe and 2 for PR HEAD 3804165 in total

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 12, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 165c7ec and 1 for PR HEAD 3804165 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b590389 and 0 for PR HEAD 3804165 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

@tvu20: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit feddea7 into openshift:master Jul 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants