Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7334: Show ConsoleSamples resources in the samples catalog #12970

Merged
merged 1 commit into from Jul 20, 2023
Merged

ODC-7334: Show ConsoleSamples resources in the samples catalog #12970

merged 1 commit into from Jul 20, 2023

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Jul 5, 2023 •
edited

Fixes:
Epic: ODC-7241: Include Serverless Function Samples in our Sample Catalog
Story: ODC-7334: Show all ConsoleSample resources in the samples catalog

Related issues:

To test the CRD you can apply it with this command to your cluster:

# delete just to ensure that you have the latest version installed
oc delete -f https://raw.githubusercontent.com/openshift/api/master/console/v1/0000_10_consolesample.crd.yaml
oc apply -f https://raw.githubusercontent.com/openshift/api/master/console/v1/0000_10_consolesample.crd.yaml

Some ConsoleSamples could be found here: https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf

oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/nodeinfo-console-samples.yaml
oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/knative-console-samples.yaml
oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/localized-console-samples.yaml

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@openshift-ci openshift-ci bot requested review from debsmita1 and spadgett July 5, 2023 07:58
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/sdk Related to console-plugin-sdk component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 5, 2023
@jerolimov jerolimov changed the title [WIP] Show ConsoleSamples resources in the samples catalog ODC-7334: Show ConsoleSamples resources in the samples catalog Jul 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2023 •
edited by openshift-ci bot

@jerolimov: This pull request references ODC-7334 which is a valid jira issue.

In response to this:

Fixes:
Epic: ODC-7241: Include Serverless Function Samples in our Sample Catalog
Story: ODC-7334: Show all ConsoleSample resources in the samples catalog

Related issues:

To test the CRD you can apply it with this command to your cluster:

oc apply -f https://raw.githubusercontent.com/jerolimov/api/console-samples/console/v1/0000_10_consolesample.crd.yaml

Some ConsoleSamples could be found here: https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf

oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/1ab9d62e1ffb616e5c925ea0e731db7df0b897e4/nodeinfo-console-samples.yaml
oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/1ab9d62e1ffb616e5c925ea0e731db7df0b897e4/knative-console-samples.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2023 •
edited by openshift-ci bot

@jerolimov: This pull request references ODC-7334 which is a valid jira issue.

In response to this:

Fixes:
Epic: ODC-7241: Include Serverless Function Samples in our Sample Catalog
Story: ODC-7334: Show all ConsoleSample resources in the samples catalog

Related issues:

To test the CRD you can apply it with this command to your cluster:

oc apply -f https://raw.githubusercontent.com/jerolimov/api/console-samples/console/v1/0000_10_consolesample.crd.yaml

Some ConsoleSamples could be found here: https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf

oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/nodeinfo-console-samples.yaml
oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/knative-console-samples.yaml
oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/localized-console-samples.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2023 •
edited by openshift-ci bot

@jerolimov: This pull request references ODC-7334 which is a valid jira issue.

In response to this:

Fixes:
Epic: ODC-7241: Include Serverless Function Samples in our Sample Catalog
Story: ODC-7334: Show all ConsoleSample resources in the samples catalog

Related issues:

To test the CRD you can apply it with this command to your cluster:

oc delete -f https://raw.githubusercontent.com/openshift/api/master/console/v1/0000_10_consolesample.crd.yaml
oc apply -f https://raw.githubusercontent.com/openshift/api/master/console/v1/0000_10_consolesample.crd.yaml

Some ConsoleSamples could be found here: https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf

oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/nodeinfo-console-samples.yaml
oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/knative-console-samples.yaml
oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/localized-console-samples.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2023 •
edited by openshift-ci bot

@jerolimov: This pull request references ODC-7334 which is a valid jira issue.

In response to this:

Fixes:
Epic: ODC-7241: Include Serverless Function Samples in our Sample Catalog
Story: ODC-7334: Show all ConsoleSample resources in the samples catalog

Related issues:

To test the CRD you can apply it with this command to your cluster:

# delete just to ensure that you have the latest version installed
oc delete -f https://raw.githubusercontent.com/openshift/api/master/console/v1/0000_10_consolesample.crd.yaml
oc apply -f https://raw.githubusercontent.com/openshift/api/master/console/v1/0000_10_consolesample.crd.yaml

Some ConsoleSamples could be found here: https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf

oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/nodeinfo-console-samples.yaml
oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/knative-console-samples.yaml
oc apply -f https://gist.github.com/jerolimov/2e557df4ea95961dd64a5c32268daadf/raw/a23b1d54f3535f329afd79c858aea6b5cbe76e4c/localized-console-samples.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov jerolimov force-pushed the console-samples branch 2 times, most recently from 8d67eb5 to 0b1bdc1 Compare July 17, 2023 00:13
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/git-service Related to git-service component/pipelines Related to pipelines-plugin labels Jul 17, 2023
@jerolimov
Copy link
Member Author

/uncc debsmita1 spadgett
/cc @lokanandaprabhu @Lucifergene @vikram-raj @sanketpathak
/assign @sanketpathak

@openshift-ci openshift-ci bot requested review from lokanandaprabhu, Lucifergene, sanketpathak and vikram-raj and removed request for spadgett and debsmita1 July 17, 2023 00:14
@jerolimov
Copy link
Member Author

Propagate from the epic

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jul 17, 2023
@jerolimov jerolimov force-pushed the console-samples branch 5 times, most recently from 57fd3ca to 6d46d2a Compare July 17, 2023 22:27
@jerolimov
Copy link
Member Author

/retest

@lokanandaprabhu
Copy link
Contributor

Tested using cluster bot.

/lgtm

Screen.Recording.2023-07-18.at.11.54.20.AM.mov

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@jerolimov
Copy link
Member Author

/retest

2 similar comments
@jerolimov
Copy link
Member Author

/retest

@invincibleJai
Copy link
Member

/retest

@sanketpathak
Copy link
Contributor

sanketpathak commented Jul 19, 2023 •
edited

Verified on cluster bot with admin and non-admin users

Screen.Recording.2023-07-19.at.6.26.57.PM.mov
Screenshot 2023-07-19 at 3 41 46 AM
Screen.Recording.2023-07-19.at.6.14.04.PM.mov

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 19, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 107a8c0 and 2 for PR HEAD 6d46d2a in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@lokanandaprabhu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 679abdd and 2 for PR HEAD db317c3 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 504df7d into openshift:master Jul 20, 2023
6 checks passed
@jerolimov jerolimov deleted the console-samples branch April 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokanandaprabhu lokanandaprabhu Awaiting requested review from lokanandaprabhu

@Lucifergene Lucifergene Awaiting requested review from Lucifergene

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

Assignees

@sanketpathak sanketpathak

@lokanandaprabhu lokanandaprabhu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jerolimov @openshift-ci-robot @lokanandaprabhu @invincibleJai @sanketpathak @openshift-merge-robot