OCPBUGS-15359: Enable namespace dropdown selection when all namespace installation mode selected by default and... #12975

sg00dwin · 2023-07-05T22:05:53Z

@jhadvig @tlwu2013

Enable namespace dropdown selection when all namespace installation mode is selected by default
Disable Automatic approval radio when non-latest version is being installed
Include info alert showing non-lastest version requires manual approval
Small correction of font sizes that are not using our base font size in the PF Catalog extension sidebar

Fixes https://issues.redhat.com/browse/OCPBUGS-15359

Namespace dropdown enabled for all namespaces installation

Disable Automatic approval radio button and display alert message

openshift-ci-robot · 2023-07-05T22:05:59Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-05T22:08:51Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-05T22:11:38Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-05T22:12:04Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-05T22:13:28Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-05T22:16:04Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-05T22:16:38Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-05T22:18:45Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-05T22:20:06Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-05T22:21:33Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-05T22:22:44Z

@sg00dwin: This pull request references Jira Issue OCPBUGS-15359, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto

Nice job, @sg00dwin! One question and a comment.

rhamilto · 2023-07-10T18:19:55Z

...s/operator-lifecycle-manager/src/components/operator-hub/operator-channel-version-select.tsx

@@ -107,6 +107,16 @@ export const OperatorVersionSelect: React.FC<OperatorVersionSelectProps> = ({
      >
        {versionSelectOptions}
      </Select>
+      {selectedUpdateVersion !== defaultVersionForChannel && (


This also appears in the modal. Is that intentional? It seems a little odd since there is no mention of the install mode in the modal.

new and improved programmatic removal!

rhamilto · 2023-07-10T18:31:55Z

...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx

-              )}
+    <>
+      <div className="form-group">
+        <RadioInput


Take 2 with this comment: Rather than duplicating these components from above, make them in to constants so there is a single source for both.

Disable Automatic approval radio when non-latest version is being installed Include info alert showing non-lastest version requires manual approval Correct font size that isn't correct in catalog extension

openshift-ci · 2023-07-15T02:14:13Z

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rhamilto

/lgtm

openshift-ci · 2023-07-17T11:50:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/operator-lifecycle-manager/OWNERS~~ [rhamilto]
~~frontend/public/style/OWNERS~~ [rhamilto,sg00dwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-07-17T16:12:11Z

@sg00dwin: Jira Issue OCPBUGS-15359: All pull requests linked via external trackers have merged:

openshift/console#12975

Jira Issue OCPBUGS-15359 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 5, 2023

openshift-ci bot requested review from yapei, rhamilto and TheRealJon July 5, 2023 22:06

openshift-ci bot added component/core Related to console core functionality component/olm Related to OLM kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 5, 2023

sg00dwin changed the title ~~OCPBUGS-15359: Enable namespace dropdown selection ...~~ OCPBUGS-15359: Enable namespace dropdown selection when all namespace installation mode selected ... Jul 5, 2023

sg00dwin changed the title ~~OCPBUGS-15359: Enable namespace dropdown selection when all namespace installation mode selected ...~~ OCPBUGS-15359: Enable namespace dropdown selection when all namespace installation mode selected by default and... Jul 5, 2023

sg00dwin assigned jhadvig Jul 5, 2023

rhamilto reviewed Jul 10, 2023

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023

sg00dwin force-pushed the enable-all-namespace-selection-for-operator-install-final branch 2 times, most recently from ca280c1 to 0abdaf7 Compare July 13, 2023 19:29

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023

Enable namespace dropdown selection

e2af35c

Disable Automatic approval radio when non-latest version is being installed Include info alert showing non-lastest version requires manual approval Correct font size that isn't correct in catalog extension

sg00dwin force-pushed the enable-all-namespace-selection-for-operator-install-final branch from 0abdaf7 to e2af35c Compare July 14, 2023 21:41

rhamilto approved these changes Jul 17, 2023

View reviewed changes

openshift-ci bot assigned rhamilto Jul 17, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023

openshift-merge-robot merged commit 1c348ab into openshift:master Jul 17, 2023
6 checks passed

sg00dwin deleted the enable-all-namespace-selection-for-operator-install-final branch July 17, 2023 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-15359: Enable namespace dropdown selection when all namespace installation mode selected by default and... #12975

OCPBUGS-15359: Enable namespace dropdown selection when all namespace installation mode selected by default and... #12975

sg00dwin commented Jul 5, 2023 •

edited

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

rhamilto left a comment

rhamilto Jul 10, 2023

sg00dwin Jul 13, 2023

sg00dwin Jul 14, 2023

rhamilto Jul 10, 2023 •

edited

sg00dwin Jul 13, 2023

openshift-ci bot commented Jul 15, 2023

rhamilto left a comment

openshift-ci bot commented Jul 17, 2023

openshift-ci-robot commented Jul 17, 2023

OCPBUGS-15359: Enable namespace dropdown selection when all namespace installation mode selected by default and... #12975

OCPBUGS-15359: Enable namespace dropdown selection when all namespace installation mode selected by default and... #12975

Conversation

sg00dwin commented Jul 5, 2023 • edited

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

openshift-ci-robot commented Jul 5, 2023

rhamilto left a comment

Choose a reason for hiding this comment

rhamilto Jul 10, 2023

Choose a reason for hiding this comment

sg00dwin Jul 13, 2023

Choose a reason for hiding this comment

sg00dwin Jul 14, 2023

Choose a reason for hiding this comment

rhamilto Jul 10, 2023 • edited

Choose a reason for hiding this comment

sg00dwin Jul 13, 2023

Choose a reason for hiding this comment

openshift-ci bot commented Jul 15, 2023

rhamilto left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jul 17, 2023

openshift-ci-robot commented Jul 17, 2023

sg00dwin commented Jul 5, 2023 •

edited

rhamilto Jul 10, 2023 •

edited