Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-10844: fix bug where binary secret values are corrupted on edit and add test coverage #12986

Merged
merged 1 commit into from Jul 10, 2023
Merged

OCPBUGS-10844: fix bug where binary secret values are corrupted on edit and add test coverage #12986

merged 1 commit into from Jul 10, 2023

Conversation

jcaianirh
Copy link
Member

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 7, 2023
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Jira Issue OCPBUGS-10844, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-10844

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/cypress Related to Cypress e2e integration testing labels Jul 7, 2023
@rhamilto rhamilto mentioned this pull request Jul 10, 2023
Closed
jhadvig
jhadvig approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 47f50a2 into openshift:master Jul 10, 2023
5 of 6 checks passed
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: Jira Issue OCPBUGS-10844: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10844 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-10844

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaianirh
Copy link
Member Author

/cherry-pick release 4.13

@openshift-cherrypick-robot
Copy link

@jcaianirh: cannot checkout release 4.13: error checking out release 4.13: exit status 1. output: error: pathspec 'release 4.13' did not match any file(s) known to git

In response to this:

/cherry-pick release 4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaianirh
Copy link
Member Author

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link

@jcaianirh: new pull request created: #12996

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 11, 2023
Closed
@jcaianirh jcaianirh mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@XiyunZhao XiyunZhao Awaiting requested review from XiyunZhao

@spadgett spadgett Awaiting requested review from spadgett

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcaianirh @openshift-ci-robot @openshift-cherrypick-robot @jhadvig @openshift-merge-robot