CONSOLE-3678: Convert EventStream component in events.jsx from class … #12989
Conversation
…component to functional component EventStream converted from a class component to a functional component in order to use react-router v6 hooks
openshift-ci-robot
added
the
jira/valid-reference
|
@tvu20: This pull request references CONSOLE-3678 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @jhadvig |
| sysEventStatus = <NoMatchingEvents allCount={allCount} />; | ||
| } | ||
| const toggleStream = () => { | ||
| setActive((prev) => !prev); |
There was a problem hiding this comment.
Love how the conversion is actually cleaning up the code 🙌
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, tvu20 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
This PR is techdebt cleanup and has no user-facing impact, so I am manually assigning docs and px approvals. /assign @yapei for QE approval. |
openshift-ci
bot
added
docs-approved
|
/assign @yanpzhan for QE approval. |
|
@XiyunZhao will test the pr. |
|
This PR has been tested on private build, with manual and regression testing, and no issue was found |
openshift-ci
bot
added
the
qe-approved
|
@tvu20: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…component to functional component
EventStream converted from a class component to a functional component in order to use react-router v6 hooks