CONSOLE-3653: Adds French Localization

[fallmo]

Adding French Localization to Console by:
Creating fr locale folders with JSON translation files for each package.
Including French in supportedLocales map

@spadgett @jhadvig

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fallmo
Once this PR has been reviewed and has the lgtm label, please assign jerolimov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@fallmo: This pull request references CONSOLE-3653 which is a valid jira issue.

In response to this:

Adding French Localization to Console by:
Creating fr locale folders with JSON translation files for each package.
Including French in supportedLocales map

@spadgett @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/retest

[jhadvig]

/retest

[jhadvig]

There is an bug filed for this PR - https://issues.redhat.com/browse/OCPBUGS-16734

[fallmo]

There is an bug filed for this PR - https://issues.redhat.com/browse/OCPBUGS-16734

Good catch, addressed it in the latest commit.

[XiyunZhao]

Hi @fallmo, there are other three issues were found for this PR, please help to take a look
OCPBUGS-16759, OCPBUGS-16761, OCPBUGS-16763

[fallmo]

Hi @fallmo, there are other three issues were found for this PR, please help to take a look OCPBUGS-16759, OCPBUGS-16761, OCPBUGS-16763

Addressed in latest commits.

[openshift-ci]

@fallmo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	0b6db93	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fallmo]

Hi @fallmo, there are other three issues were found for this PR, please help to take a look OCPBUGS-16759, OCPBUGS-16761, OCPBUGS-16763

Addressed in latest commits.

@jhadvig @XiyunZhao hello, any updates since?

[jhadvig]

@fallmo thank you for reaching out. We are waiting for the QE team to approve the change. Sorry for the delay.

[XiyunZhao]

sorry for the delay, all bug has been verified on pre-merge testing, all passed, and no other new issue was found
/label qe-approved

[fallmo]

sorry for the delay, all bug has been verified on pre-merge testing, all passed, and no other new issue was found /label qe-approved

Great news!

[ymoisan]

FR in OpenShift would be really nice :-)

[fallmo]

FR in OpenShift would be really nice :-)

Agreed!

[fallmo]

@jhadvig @spadgett hey there, any new bugs show up? What are the next steps?

[yanpzhan]

@jhadvig this pr is still open, will it be include in 4.15?

[jhadvig]

Unfortunately we need to close this PR since there is no business requirement for this feature anymore.

[pittar]

Every department in the Government of Canada is waiting on this feature - how can there be no business requirement?