Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-9991: Most of contents are lack of i18n on "Command Line Tools" page #12995

Conversation

Mylanos
Copy link
Contributor

@Mylanos Mylanos commented Jul 11, 2023

fixes: https://issues.redhat.com/browse/OCPBUGS-9991

Added i18n support for string in the command line tools page, localization support for these string was previously missing. The issue regarding the pseudolocalization should now be fixed for all of the static content. Remaining string content is dynamically loaded, so the localization is not possible.

screenshot of the state before
image

screenshot with the pseudolocalized headline, the remaining part of the page is dynamically loaded.
image

Localization support for these string was missing.
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 11, 2023
@openshift-ci-robot
Copy link
Contributor

@Mylanos: This pull request references Jira Issue OCPBUGS-9991, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

fixes: https://issues.redhat.com/browse/OCPBUGS-9991

Added i18n support for string in the command line tools page, localization support for these string was previously missing. The issue regarding the pseudolocalization should now be fixed for all of the static content. Remaining string content is dynamically loaded, so the localization is not possible.

screenshot of the state before
image

screenshot with the pseudolocalized headline, the remaining part of the page is dynamically loaded.
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from yapei, jcaianirh and kyoto July 11, 2023 14:23
@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 11, 2023
@Mylanos
Copy link
Contributor Author

Mylanos commented Jul 11, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

@Mylanos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit 165c7ec into openshift:master Jul 12, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@Mylanos: Jira Issue OCPBUGS-9991: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-9991 has been moved to the MODIFIED state.

In response to this:

fixes: https://issues.redhat.com/browse/OCPBUGS-9991

Added i18n support for string in the command line tools page, localization support for these string was previously missing. The issue regarding the pseudolocalization should now be fixed for all of the static content. Remaining string content is dynamically loaded, so the localization is not possible.

screenshot of the state before
image

screenshot with the pseudolocalized headline, the remaining part of the page is dynamically loaded.
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants