New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-9991: Most of contents are lack of i18n on "Command Line Tools" page #12995
OCPBUGS-9991: Most of contents are lack of i18n on "Command Line Tools" page #12995
Conversation
Localization support for these string was missing.
@Mylanos: This pull request references Jira Issue OCPBUGS-9991, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
@Mylanos: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, Mylanos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Mylanos: Jira Issue OCPBUGS-9991: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-9991 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fixes: https://issues.redhat.com/browse/OCPBUGS-9991
Added i18n support for string in the command line tools page, localization support for these string was previously missing. The issue regarding the pseudolocalization should now be fixed for all of the static content. Remaining string content is dynamically loaded, so the localization is not possible.
screenshot of the state before
screenshot with the pseudolocalized headline, the remaining part of the page is dynamically loaded.