Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16025,OCPBUGS-14837: Hide the Duplicate Pipelines Card in the DevConsole Add Page #13007

Merged
merged 1 commit into from Jul 19, 2023

Conversation

vikram-raj
Copy link
Member

Fixes: https://issues.redhat.com/browse/OCPBUGS-14837 and https://issues.redhat.com/browse/OCPBUGS-16025

Descriptions:

  • Previously duplicate was shown on the add page when Openshift Pipeline operator 1.11 is installed as both the API versions v1 and v1beta1 are enabled. Fixed it by introducing a new flag that checks for the operator version.
  • Pipeline tab was not visible on the 4.14 cluster if older than 1.11 Pipeline Operator is installed. Fixed by making entries for the v1beta1 API version in the console-extension.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 13, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-14837, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-14837 and https://issues.redhat.com/browse/OCPBUGS-16025

Descriptions:

  • Previously duplicate was shown on the add page when Openshift Pipeline operator 1.11 is installed as both the API versions v1 and v1beta1 are enabled. Fixed it by introducing a new flag that checks for the operator version.
  • Pipeline tab was not visible on the 4.14 cluster if older than 1.11 Pipeline Operator is installed. Fixed by making entries for the v1beta1 API version in the console-extension.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sanketpathak July 13, 2023 10:37
@vikram-raj
Copy link
Member Author

/cc @lokanandaprabhu @Lucifergene

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2023
@vikram-raj vikram-raj changed the title OCPBUGS-16025, OCPBUGS-14837: Hide the Duplicate Pipelines Card in the DevConsole Add Page OCPBUGS-16025,OCPBUGS-14837: Hide the Duplicate Pipelines Card in the DevConsole Add Page Jul 13, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-16025, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-14837, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-14837 and https://issues.redhat.com/browse/OCPBUGS-16025

Descriptions:

  • Previously duplicate was shown on the add page when Openshift Pipeline operator 1.11 is installed as both the API versions v1 and v1beta1 are enabled. Fixed it by introducing a new flag that checks for the operator version.
  • Pipeline tab was not visible on the 4.14 cluster if older than 1.11 Pipeline Operator is installed. Fixed by making entries for the v1beta1 API version in the console-extension.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 14, 2023
Copy link
Contributor

@Lucifergene Lucifergene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Lucifergene
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 107a8c0 and 2 for PR HEAD 402e64b in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1e9903f into openshift:master Jul 19, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: Jira Issue OCPBUGS-16025: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16025 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-14837: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14837 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-14837 and https://issues.redhat.com/browse/OCPBUGS-16025

Descriptions:

  • Previously duplicate was shown on the add page when Openshift Pipeline operator 1.11 is installed as both the API versions v1 and v1beta1 are enabled. Fixed it by introducing a new flag that checks for the operator version.
  • Pipeline tab was not visible on the 4.14 cluster if older than 1.11 Pipeline Operator is installed. Fixed by making entries for the v1beta1 API version in the console-extension.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj deleted the ocpbugs-16025 branch July 26, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants