Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-16599: allow creation of v1beta1 APIversion Pipeline in Pipeline builder YAML view #13034

Merged
merged 1 commit into from Jul 25, 2023
Merged

OCPBUGS-16599: allow creation of v1beta1 APIversion Pipeline in Pipeline builder YAML view #13034

merged 1 commit into from Jul 25, 2023

Conversation

vikram-raj
Copy link
Member

@vikram-raj vikram-raj changed the title allow creation of v1beta1 APIversion Pipeline in Pipeline builder YAML view OCPBUGS-16599: allow creation of v1beta1 APIversion Pipeline in Pipeline builder YAML view Jul 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 21, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-16599, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-16599

GIF:
https://github.com/openshift/console/assets/2561818/28be2e2a-3065-4e16-8f41-1e1036921a8f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2023
@vikram-raj
Copy link
Member Author

/cc @Lucifergene @lokanandaprabhu
/uncc @andrewballantyne @divyanshiGupta

@openshift-ci openshift-ci bot requested review from lokanandaprabhu and Lucifergene and removed request for andrewballantyne and divyanshiGupta July 21, 2023 10:02
@vikram-raj
Copy link
Member Author

/retest

@Lucifergene
Copy link
Contributor

/assign @Lucifergene

Lucifergene
Lucifergene reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@Lucifergene Lucifergene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI works as expected. v1beta1 is working.

Tab-Pipeline.builder.OKD.mp4

@Lucifergene
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5a153da and 2 for PR HEAD caeebc2 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit edfb379 into openshift:master Jul 25, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: Jira Issue OCPBUGS-16599: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16599 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-16599

GIF:
https://github.com/openshift/console/assets/2561818/28be2e2a-3065-4e16-8f41-1e1036921a8f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj deleted the ocpbugs-16599 branch July 25, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucifergene Lucifergene Lucifergene left review comments

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@lokanandaprabhu lokanandaprabhu Awaiting requested review from lokanandaprabhu

Assignees

@Lucifergene Lucifergene

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vikram-raj @openshift-ci-robot @Lucifergene @openshift-merge-robot