Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-16659: Fix RTE in bridge. #13038

Merged
merged 1 commit into from Aug 3, 2023
Merged

[release-4.13] OCPBUGS-16659: Fix RTE in bridge. #13038

merged 1 commit into from Aug 3, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #12817

/assign TheRealJon

@TheRealJon
OCPBUGS-13693: Fix RTE in bridge.
5e444a9 
Fix pkg/serverconfig/metrics.go b/pkg/serverconfig/metrics.go getConsolePlugins func that can throw a runtime exception if console plugins request fails.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 21, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-13693 has been cloned as Jira Issue OCPBUGS-16659. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-16659: Fix RTE in bridge.

In response to this:

This is an automated cherry-pick of #12817

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-13693: Fix RTE in bridge. [release-4.13] OCPBUGS-16659: Fix RTE in bridge. Jul 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 21, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-16659, which is invalid:

  • expected dependent Jira Issue OCPBUGS-13693 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #12817

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from florkbr and jhadvig July 21, 2023 19:41
@openshift-ci openshift-ci bot added the component/backend Related to backend label Jul 21, 2023
@cblecker
Copy link
Member

/test e2e-gcp-console

@cblecker
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 26, 2023
@openshift-ci-robot
Copy link
Contributor

@cblecker: This pull request references Jira Issue OCPBUGS-16659, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13693 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13693 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 26, 2023
@openshift-ci openshift-ci bot requested a review from yapei July 26, 2023 18:24
spadgett
spadgett approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/backport-risk-assessed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@cblecker
Copy link
Member

/retest

2 similar comments
@cblecker
Copy link
Member

/retest

@cblecker
Copy link
Member

/retest

@yanpzhan
Copy link
Contributor

Reproduced the bug on old code without the fix: run "./build.sh", source "/contrib/oc-environment.sh", but some env vars such as "BRIDGE_K8S_MODE_OFF_CLUSTER_ALERTMANAGER" are not set or not correct, run "./bin/bridge" will exit with runtime error about plugin failure.
Tried with code in this pr with same steps, there is log for "Failed to get all installed ConsolePlugins", bridge will go on running.
/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jul 28, 2023
@yanpzhan
Copy link
Contributor

yanpzhan commented Aug 1, 2023

/retest

@jhadvig
Copy link
Member

jhadvig commented Aug 2, 2023

/retest

@sdodson sdodson added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a0ce922 into openshift:release-4.13 Aug 3, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-16659: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16659 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #12817

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2023-08-03-105759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@florkbr florkbr Awaiting requested review from florkbr

@jhadvig jhadvig Awaiting requested review from jhadvig

@yapei yapei Awaiting requested review from yapei

Assignees

@spadgett spadgett

@gouyang gouyang

@jrichter1 jrichter1

@ebenahar ebenahar

@sanketpathak sanketpathak

@TheRealJon TheRealJon

@juzhao juzhao

@The-Anton The-Anton

@lihongyan1 lihongyan1

@Tai-RedHat Tai-RedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/backend Related to backend jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet