ODC-7539: Update devfile library to v2.2.2

[maysunfaisal]

Description

This PR updates to a newer version of devfile/library. The devfile/library go mod version that has been selected includes the updated devfile validation, whereby the ports defined in the devfile sample can now be more uniform and consistent. For example, take a peak at the Quakus devfile sample for this port change devfile-samples/devfile-sample-code-with-quarkus#23

For a list of the feature updates on devfile/library, see the release v2.2.1

Issue

Fixes devfile/api#1136

Testing

Build an image from branch, push to quay and update the console container with the quay image.

Notes

We should also be back porting this to a few releases.

[maysunfaisal]

@jerolimov are you still monitoring the code base from devfile POV? If you are, I would be grateful if you could also please take a look!

[vikram-raj]

/cc @jhadvig

[maysunfaisal]

/retest-required

[maysunfaisal]

/retest

[maysunfaisal]

/retest

[maysunfaisal]

/retest

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[maysunfaisal]

@thepetk could you please use this branch and test it with the new registry index with multiple versions? It is now pulling the latest devfile/library

[thepetk]

/lgtm

I've tested the updated console with the existing registry index:

• Was able to fetch all devfile samples.
• Was able to build an application for each one of the samples.

Another thing I've tried to test the latest changes, was to try to import from git a temp branch I've created for the go-basic sample which has two components using the same port 8080. The updated console was able to validate & build the devfile, which is not allowed atm for console as it uses an older version of devfile library. The example code is here: https://github.com/thepetk/devfile-sample-go-basic/tree/temp_branch

cc @maysunfaisal

[openshift-ci]

@maysunfaisal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jerolimov]

/remove-lifecycle stale

[jerolimov]

/assign @jerolimov
/cc @jerolimov @sanketpathak @The-Anton

[jerolimov]

This change works really fine. I've tested this on a cluster bot and verified that all 6 included samples works fine:

I've also verified this some years old repos to verify that we don't just support the latest version:

• https://github.com/redhat-developer/devfile-sample (same error)
• https://github.com/jerolimov/devfile-sample
• https://github.com/jerolimov/devfile-sample-code-with-quarkus
• https://github.com/jerolimov/devfile-sample-go-basic-inlined
• https://github.com/jerolimov/devfile-sample-go-basic-private
• https://github.com/jerolimov/devfile-sample-go-basic-broken (same error)
• https://github.com/jerolimov/devfile-sample-go-basic-absolute-k8s-uri (same, builds fine, issues starting the pod)
• https://github.com/jerolimov/devfile2-experiment (same error)
• https://github.com/jerolimov/devfile-sample-go-basic-no-k8s-resources (same error)

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, maysunfaisal, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerolimov]

/retitle ODC-7539: Update devfile library to v2.2.2

[openshift-ci-robot]

@maysunfaisal: This pull request references ODC-7539 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Description

This PR updates to a newer version of devfile/library. The devfile/library go mod version that has been selected includes the updated devfile validation, whereby the ports defined in the devfile sample can now be more uniform and consistent. For example, take a peak at the Quakus devfile sample for this port change devfile-samples/devfile-sample-code-with-quarkus#23

For a list of the feature updates on devfile/library, see the release v2.2.1

Issue

Fixes devfile/api#1136

Testing

Build an image from branch, push to quay and update the console container with the quay image.

Notes

We should also be back porting this to a few releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jerolimov]

It's a go library update and I spend a lot of time to test different use case...

/label px-approved
/label docs-approved
/jira refresh

[openshift-ci-robot]

@jerolimov: This pull request references ODC-7539 which is a valid jira issue.

In response to this:

It's a go library update and I spend a lot of time to test different use case...

/label px-approved
/label docs-approved
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sanketpathak]

Verified with admin and non-admin users

/label qe-approved

[openshift-ci-robot]

@maysunfaisal: This pull request references ODC-7539 which is a valid jira issue.

In response to this:

Description

This PR updates to a newer version of devfile/library. The devfile/library go mod version that has been selected includes the updated devfile validation, whereby the ports defined in the devfile sample can now be more uniform and consistent. For example, take a peak at the Quakus devfile sample for this port change devfile-samples/devfile-sample-code-with-quarkus#23

For a list of the feature updates on devfile/library, see the release v2.2.1

Issue

Fixes devfile/api#1136

Testing

Build an image from branch, push to quay and update the console container with the quay image.

Notes

We should also be back porting this to a few releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.