OCPBUGS-16693, OCPBUGS-13387: Import page create button is disabled due to PAC validation

[lokanandaprabhu]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-16693
https://issues.redhat.com/browse/OCPBUGS-13387

Analysis / Root cause:
On selecting of default pipeline from the cluster, PAC validation was happening, so the create button is disabled

Solution Description:
Added validation only if the pipeline type is PAC

Screen shots / Gifs for design review:

Screen.Recording.2023-07-25.at.2.34.08.PM.mov

Screen.Recording.2023-07-25.at.2.35.31.PM.mov

Unit test coverage report:
NA

Test setup:
-----OCPBUGS-16693----

1. Go to Import from Git page
2. Add repository https://bitbucket.org/lokanandap/hello-func
3. Select Use Pipeline from this cluster in Add Pipeline section

---OCPBUGS-13387---

1. In import from git form enter the git URL https://github.com/Lucifergene/oc-pipe-func
2. Pipeline is checked and PAC option is selected by default even if user uncheck the Pipeline option user get the same error
3. click Create button

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-16693, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-16693

Analysis / Root cause:
On selecting of default pipeline from the cluster, PAC validation was happening, so the create button is disabled

Solution Description:
Added validation only if the pipeline type is PAC

Screen shots / Gifs for design review:

Unit test coverage report:
NA

Test setup:

1. Go to Import from Git page
2. Add repository https://bitbucket.org/lokanandap/hello-func
3. Select Use Pipeline from this cluster in Add Pipeline section

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-13387, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-16693

Analysis / Root cause:
On selecting of default pipeline from the cluster, PAC validation was happening, so the create button is disabled

Solution Description:
Added validation only if the pipeline type is PAC

Screen shots / Gifs for design review:

Unit test coverage report:
NA

Test setup:

1. Go to Import from Git page
2. Add repository https://bitbucket.org/lokanandap/hello-func
3. Select Use Pipeline from this cluster in Add Pipeline section

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-13387, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-16693
https://issues.redhat.com/browse/OCPBUGS-13387

Analysis / Root cause:
On selecting of default pipeline from the cluster, PAC validation was happening, so the create button is disabled

Solution Description:
Added validation only if the pipeline type is PAC

Screen shots / Gifs for design review:

Unit test coverage report:
NA

Test setup:
-----OCPBUGS-16693----

1. Go to Import from Git page
2. Add repository https://bitbucket.org/lokanandap/hello-func
3. Select Use Pipeline from this cluster in Add Pipeline section

---OCPBUGS-13387---

1. In import from git form enter the git URL https://github.com/lance/viewer
2. Pipeline is checked and PAC option is selected by default even if user uncheck the Pipeline option user get the same error
3. click Create button

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-13387, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-16693
https://issues.redhat.com/browse/OCPBUGS-13387

Analysis / Root cause:
On selecting of default pipeline from the cluster, PAC validation was happening, so the create button is disabled

Solution Description:
Added validation only if the pipeline type is PAC

Screen shots / Gifs for design review:

Screen.Recording.2023-07-25.at.2.34.08.PM.mov

Screen.Recording.2023-07-25.at.2.35.31.PM.mov

Unit test coverage report:
NA

Test setup:
-----OCPBUGS-16693----

1. Go to Import from Git page
2. Add repository https://bitbucket.org/lokanandap/hello-func
3. Select Use Pipeline from this cluster in Add Pipeline section

---OCPBUGS-13387---

1. In import from git form enter the git URL https://github.com/lance/viewer
2. Pipeline is checked and PAC option is selected by default even if user uncheck the Pipeline option user get the same error
3. click Create button

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lokanandaprabhu]

/cc @vikram-raj @Lucifergene

[Lucifergene]

/retest

[lokanandaprabhu]

/retest

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-13387, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-16693
https://issues.redhat.com/browse/OCPBUGS-13387

Analysis / Root cause:
On selecting of default pipeline from the cluster, PAC validation was happening, so the create button is disabled

Solution Description:
Added validation only if the pipeline type is PAC

Screen shots / Gifs for design review:

Screen.Recording.2023-07-25.at.2.34.08.PM.mov

Screen.Recording.2023-07-25.at.2.35.31.PM.mov

Unit test coverage report:
NA

Test setup:
-----OCPBUGS-16693----

1. Go to Import from Git page
2. Add repository https://bitbucket.org/lokanandap/hello-func
3. Select Use Pipeline from this cluster in Add Pipeline section

---OCPBUGS-13387---

1. In import from git form enter the git URL https://github.com/Lucifergene/oc-pipe-func
2. Pipeline is checked and PAC option is selected by default even if user uncheck the Pipeline option user get the same error
3. click Create button

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Lucifergene]

Satisfies all the edge cases.

• Without Serverless Operator installed
• With Serverless operator installed
• With the Pipeline Templates installed

/lgtm

[Lucifergene]

/retest

[lokanandaprabhu]

Propage labels from the epic:

/label docs-approved
/label px-approved

[vikram-raj]

When I import a repo that has func.yaml, it detected the import strategy as a serverless function, and in the Pipeline section, it shows an alert as the pipeline is not present for the Serverless function. But when I switch to the Builder Image import strategy it still shows the same alert instead of showing the pipeline for a combination of Serverless deployment and node.js. See the GIF below

GH-13046-issue.mov

[vikram-raj]

/retest

[vikram-raj]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [vikram-raj]
• frontend/packages/pipelines-plugin/OWNERS [vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@lokanandaprabhu: Jira Issue OCPBUGS-13387: All pull requests linked via external trackers have merged:

• openshift/console#13046

Jira Issue OCPBUGS-13387 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-16693
https://issues.redhat.com/browse/OCPBUGS-13387

Analysis / Root cause:
On selecting of default pipeline from the cluster, PAC validation was happening, so the create button is disabled

Solution Description:
Added validation only if the pipeline type is PAC

Screen shots / Gifs for design review:

Screen.Recording.2023-07-25.at.2.34.08.PM.mov

Screen.Recording.2023-07-25.at.2.35.31.PM.mov

Unit test coverage report:
NA

Test setup:
-----OCPBUGS-16693----

1. Go to Import from Git page
2. Add repository https://bitbucket.org/lokanandap/hello-func
3. Select Use Pipeline from this cluster in Add Pipeline section

---OCPBUGS-13387---

1. In import from git form enter the git URL https://github.com/Lucifergene/oc-pipe-func
2. Pipeline is checked and PAC option is selected by default even if user uncheck the Pipeline option user get the same error
3. click Create button

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lokanandaprabhu]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@lokanandaprabhu: new pull request created: #13116

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.