Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17196: Fix nad ovn type - annotation and netAttachName #13053

Merged

Conversation

metalice
Copy link
Contributor

OVN type NetworkAttachmentDefinition - fix netAttachName fields order, namespace/name
Remove annotation for this type

https://issues.redhat.com/browse/CNV-31358

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 31, 2023

@metalice: This pull request references CNV-31358 which is a valid jira issue.

In response to this:

OVN type NetworkAttachmentDefinition - fix netAttachName fields order, namespace/name
Remove annotation for this type

https://issues.redhat.com/browse/CNV-31358

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/network-attachment-definition Related to network-attachment-definition label Jul 31, 2023
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@metalice metalice changed the title CNV-31358: Fix nad ovn type - annotation and netAttachName OCPBUGS-17196: Fix nad ovn type - annotation and netAttachName Aug 2, 2023
@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Aug 2, 2023
@openshift-ci-robot
Copy link
Contributor

@metalice: This pull request references Jira Issue OCPBUGS-17196, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OVN type NetworkAttachmentDefinition - fix netAttachName fields order, namespace/name
Remove annotation for this type

https://issues.redhat.com/browse/CNV-31358

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 2, 2023
@metalice
Copy link
Contributor Author

metalice commented Aug 2, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@metalice: This pull request references Jira Issue OCPBUGS-17196, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metalice
Copy link
Contributor Author

metalice commented Aug 2, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 2, 2023
@openshift-ci-robot
Copy link
Contributor

@metalice: This pull request references Jira Issue OCPBUGS-17196, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei August 2, 2023 12:52
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

@metalice: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2a2e343 into openshift:master Aug 2, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@metalice: Jira Issue OCPBUGS-17196: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17196 has been moved to the MODIFIED state.

In response to this:

OVN type NetworkAttachmentDefinition - fix netAttachName fields order, namespace/name
Remove annotation for this type

https://issues.redhat.com/browse/CNV-31358

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/network-attachment-definition Related to network-attachment-definition jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants