Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-15474: Project admin can update and view subscription from operator details page #13056

Merged
merged 2 commits into from
Oct 5, 2023
Merged

[release-4.12] OCPBUGS-15474: Project admin can update and view subscription from operator details page #13056

merged 2 commits into from
Oct 5, 2023

Conversation

TheRealJon
Copy link
Member

Manual backport of #12780
Depends on #13055

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 31, 2023
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Jira Issue OCPBUGS-15474, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12785 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-12785 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual backport of #12780
Depends on #13055

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei July 31, 2023 19:19
@TheRealJon
Copy link
Member Author

/hold

Wait for #13055

@TheRealJon TheRealJon marked this pull request as draft July 31, 2023 19:20
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 31, 2023
@TheRealJon
Copy link
Member Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. component/backend Related to backend component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM labels Jul 31, 2023
@TheRealJon
Copy link
Member Author

/retest

@TheRealJon TheRealJon marked this pull request as ready for review September 13, 2023 14:04
@TheRealJon
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 13, 2023
@TheRealJon
OCPBUGS-3036: Do not list subscriptions in all namespaces on CSV deta…
38a98f4 
…ils page.
@TheRealJon
CONSOLE-12286: Fix missing console plugin control on CSV details page.
834186d 
ClusterServiceVersionDetails component expected a `subscriptions` prop which was removed in another bug fix. Update ClusterServiceVersionDetailsPage to pass `subscriptions, subscription, subscriptionsLoaded, subscriptionsLoadError` props through the `customData` prop of `DetailsPage` component. This will make these properties available to all tab pages on the CSV details page.
@jcaianirh
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaianirh
Copy link
Member

/backport-risk-assessed

@TheRealJon
Copy link
Member Author

/retest

@XiyunZhao
Copy link

XiyunZhao commented Sep 14, 2023 •
edited

@TheRealJon since #12717 is tracking as a separate bug, I approve this one first, help to make sure the 4.12 backport PR for #12717 is in progress, otherwise catalog source info is invisible on Subscription page
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 14, 2023
@yanpzhan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 15, 2023
@TheRealJon
Copy link
Member Author

/retest

2 similar comments
@TheRealJon
Copy link
Member Author

/retest

@TheRealJon
Copy link
Member Author

/retest

@jhadvig
Copy link
Member

jhadvig commented Sep 25, 2023

/label backport-risk-assessed
/retest

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 25, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1998a68 and 2 for PR HEAD 834186d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c8d9cfd and 1 for PR HEAD 834186d in total

@TheRealJon
Copy link
Member Author

/retest

@TheRealJon
Copy link
Member Author

/retest
timed out

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 41ca4d6 into openshift:release-4.12 Oct 5, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: Jira Issue OCPBUGS-15474: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15474 has been moved to the MODIFIED state.

In response to this:

Manual backport of #12780
Depends on #13055

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-10-06-172224

@TheRealJon TheRealJon deleted the OCPBUGS-15474 branch October 10, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaianirh jcaianirh jcaianirh approved these changes

@yapei yapei Awaiting requested review from yapei

@florkbr florkbr Awaiting requested review from florkbr

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

Assignees

@gouyang gouyang

@jrichter1 jrichter1

@ebenahar ebenahar

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@juzhao juzhao

@jcaianirh jcaianirh

@The-Anton The-Anton

@lihongyan1 lihongyan1

@Tai-RedHat Tai-RedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/backend Related to backend component/core Related to console core functionality component/olm Related to OLM jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet