Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17203: mock apis for git repo in test serverless function tests #13064

Conversation

sanketpathak
Copy link
Contributor

@sanketpathak sanketpathak commented Aug 2, 2023

Fix: https://issues.redhat.com/browse/OCPBUGS-17203
Problem: Running test serverless function tests were giving rate limit issue

Solution: Mock the git url to avoid the rate limit issue.

Test Setup:

  • Cluster should be running on local

  • Change TAGS in frontend/packages/knative-plugin/integration-tests/cypress.json file to : "@smoke or @regression and not (@Manual or @to-do or @un-verified)",

  • Command to execute:

    • yarn run dev
    • yarn run test-cypress-knative
  • Execute the serverless-function.feature file

Browser
Chrome 114

Test Execution Screenshot:

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/knative Related to knative-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 2, 2023
@sanketpathak sanketpathak changed the title mock apis for git repo in test serverless function tests OCPBUGS-17203: mock apis for git repo in test serverless function tests Aug 2, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 2, 2023
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Jira Issue OCPBUGS-17203, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix: https://issues.redhat.com/browse/OCPBUGS-17203
Problem: Running test serverless function tests were giving rate limit issue

Solution: Mock the git url to avoid the rate limit issue.

Test Setup:

  • Cluster should be running on local

  • Change TAGS in frontend/packages/knative-plugin/integration-tests/cypress.json file to : "@smoke or @regression and not (@Manual or @to-do or @un-verified)",

  • Command to execute:

    • yarn run dev
    • yarn run test-cypress-knative
  • Execute the filter-quick-starts-catalog.feature file

Browser
Chrome 114

Test Execution Screenshot:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanketpathak
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 2, 2023
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Jira Issue OCPBUGS-17203, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sanketpathak: This pull request references Jira Issue OCPBUGS-17203, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Jira Issue OCPBUGS-17203, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fix: https://issues.redhat.com/browse/OCPBUGS-17203
Problem: Running test serverless function tests were giving rate limit issue

Solution: Mock the git url to avoid the rate limit issue.

Test Setup:

  • Cluster should be running on local

  • Change TAGS in frontend/packages/knative-plugin/integration-tests/cypress.json file to : "@smoke or @regression and not (@Manual or @to-do or @un-verified)",

  • Command to execute:

    • yarn run dev
    • yarn run test-cypress-knative
  • Execute the test-serverless-function.feature file

Browser
Chrome 114

Test Execution Screenshot:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sanketpathak: This pull request references Jira Issue OCPBUGS-17203, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fix: https://issues.redhat.com/browse/OCPBUGS-17203
Problem: Running test serverless function tests were giving rate limit issue

Solution: Mock the git url to avoid the rate limit issue.

Test Setup:

  • Cluster should be running on local

  • Change TAGS in frontend/packages/knative-plugin/integration-tests/cypress.json file to : "@smoke or @regression and not (@Manual or @to-do or @un-verified)",

  • Command to execute:

    • yarn run dev
    • yarn run test-cypress-knative
  • Execute the test-serverless-function.feature file

Browser
Chrome 114

Test Execution Screenshot:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Jira Issue OCPBUGS-17203, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fix: https://issues.redhat.com/browse/OCPBUGS-17203
Problem: Running test serverless function tests were giving rate limit issue

Solution: Mock the git url to avoid the rate limit issue.

Test Setup:

  • Cluster should be running on local

  • Change TAGS in frontend/packages/knative-plugin/integration-tests/cypress.json file to : "@smoke or @regression and not (@Manual or @to-do or @un-verified)",

  • Command to execute:

    • yarn run dev
    • yarn run test-cypress-knative
  • Execute the serverless-function.feature file

Browser
Chrome 114

Test Execution Screenshot:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sanketpathak: This pull request references Jira Issue OCPBUGS-17203, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fix: https://issues.redhat.com/browse/OCPBUGS-17203
Problem: Running test serverless function tests were giving rate limit issue

Solution: Mock the git url to avoid the rate limit issue.

Test Setup:

  • Cluster should be running on local

  • Change TAGS in frontend/packages/knative-plugin/integration-tests/cypress.json file to : "@smoke or @regression and not (@Manual or @to-do or @un-verified)",

  • Command to execute:

    • yarn run dev
    • yarn run test-cypress-knative
  • Execute the serverless-function.feature file

Browser
Chrome 114

Test Execution Screenshot:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanketpathak sanketpathak force-pushed the mock-api-test-serverless-function branch 3 times, most recently from 276a844 to d033a72 Compare August 28, 2023 06:49
@sanketpathak sanketpathak force-pushed the mock-api-test-serverless-function branch from d033a72 to 65ad1a5 Compare September 4, 2023 11:52
@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Sep 4, 2023
@Lucifergene
Copy link
Contributor

/assign @Lucifergene

@sanketpathak
Copy link
Contributor Author

/test e2e-gcp-console

@sanketpathak
Copy link
Contributor Author

/retest

Copy link
Contributor

@Lucifergene Lucifergene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanketpathak Out of the 12 tests in the Serverless Functions, 8 are passing and 4 are failing. In all the 4 failures, I am seeing this same error message

image

@Lucifergene
Copy link
Contributor

Since the failing tests are manual and don't need to be executed, the tests can be considered passing.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lucifergene, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanketpathak
Copy link
Contributor Author

sanketpathak commented Sep 6, 2023

Changes only affects our e2e tests
/label qe-approved
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Sep 6, 2023
@openshift-bot
Copy link
Contributor

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 8, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Jira Issue OCPBUGS-17203, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanketpathak
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 8, 2023
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Jira Issue OCPBUGS-17203, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sanketpathak: This pull request references Jira Issue OCPBUGS-17203, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c045ad4 and 2 for PR HEAD 65ad1a5 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

@sanketpathak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b48254b into openshift:master Sep 18, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: Jira Issue OCPBUGS-17203: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17203 has been moved to the MODIFIED state.

In response to this:

Fix: https://issues.redhat.com/browse/OCPBUGS-17203
Problem: Running test serverless function tests were giving rate limit issue

Solution: Mock the git url to avoid the rate limit issue.

Test Setup:

  • Cluster should be running on local

  • Change TAGS in frontend/packages/knative-plugin/integration-tests/cypress.json file to : "@smoke or @regression and not (@Manual or @to-do or @un-verified)",

  • Command to execute:

    • yarn run dev
    • yarn run test-cypress-knative
  • Execute the serverless-function.feature file

Browser
Chrome 114

Test Execution Screenshot:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanketpathak
Copy link
Contributor Author

/cherry-pick 4.14

@openshift-cherrypick-robot

@sanketpathak: cannot checkout 4.14: error checking out 4.14: exit status 1. output: error: pathspec '4.14' did not match any file(s) known to git

In response to this:

/cherry-pick 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanketpathak
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot

@sanketpathak: new pull request created: #13199

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants