New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-13152: fetch TaskRuns without selector and reduces the get TaskRuns requests #13065
OCPBUGS-13152: fetch TaskRuns without selector and reduces the get TaskRuns requests #13065
Conversation
@vikram-raj: This pull request references Jira Issue OCPBUGS-13152, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @jerolimov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally and I saw a lot of delays with the old implementation and less with the new one.
Also if the new implementation downloads ALL TaskRuns. It's similar to how we fetch PipelineRuns.
Better than before and works as expected. 👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vikram-raj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@vikram-raj: Jira Issue OCPBUGS-13152: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-13152 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.14 |
@vikram-raj: new pull request created: #13178 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353 |
Fixes: https://issues.redhat.com/browse/OCPBUGS-13152
Descriptions: Fetch TaskRuns without selector and also remove the fetching of TaskRuns per Rows of Pipeline, PipelineRun and Repository
Before:
fetch-taskrun-before.mov
After:
fetch-taskRun-after.mov