Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17496: Bridge NAD should set "preserveDefaultVlan": false #13076

Merged
merged 1 commit into from Aug 14, 2023

Conversation

avivtur
Copy link
Contributor

@avivtur avivtur commented Aug 7, 2023

Adding "preserveDefaultVlan": false to NAD's config when creating a bridged NAD with the UI

Before:

fix-nad-config-b4.mp4

After:

fix-nad-config.mp4

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2023

@avivtur: This pull request references CNV-31770 which is a valid jira issue.

In response to this:

Adding "preserveDefaultVlan": false to NAD's config when creating a bridged NAD with the UI

Before:

fix-nad-config-b4.mp4

After:

fix-nad-config.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/network-attachment-definition Related to network-attachment-definition label Aug 7, 2023
@pcbailey
Copy link
Contributor

pcbailey commented Aug 8, 2023

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@avivtur: Can not set label jira/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

In response to this:

/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avivtur avivtur changed the title CNV-31770: Bridge NAD should set "preserveDefaultVlan": false OCPBUGS-17496: Bridge NAD should set "preserveDefaultVlan": false Aug 9, 2023
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 9, 2023
@openshift-ci-robot
Copy link
Contributor

@avivtur: This pull request references Jira Issue OCPBUGS-17496, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Adding "preserveDefaultVlan": false to NAD's config when creating a bridged NAD with the UI

Before:

fix-nad-config-b4.mp4

After:

fix-nad-config.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avivtur
Copy link
Contributor Author

avivtur commented Aug 9, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 9, 2023
@openshift-ci-robot
Copy link
Contributor

@avivtur: This pull request references Jira Issue OCPBUGS-17496, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei August 9, 2023 06:57
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, jhadvig, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 18624e8 and 2 for PR HEAD fe766a8 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4546dc5 and 1 for PR HEAD fe766a8 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0f91327 and 0 for PR HEAD fe766a8 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision fe766a8 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
@avivtur
Copy link
Contributor Author

avivtur commented Aug 14, 2023

/unhold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

@avivtur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6143838 into openshift:master Aug 14, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@avivtur: Jira Issue OCPBUGS-17496: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17496 has been moved to the MODIFIED state.

In response to this:

Adding "preserveDefaultVlan": false to NAD's config when creating a bridged NAD with the UI

Before:

fix-nad-config-b4.mp4

After:

fix-nad-config.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/network-attachment-definition Related to network-attachment-definition jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants