Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17948: Fix that Devconsole plugin show essential features like add page and topology also when Builds and DeploymentConfigs capabilities are disabled #13097

Merged
merged 1 commit into from Aug 23, 2023
Merged

OCPBUGS-17948: Fix that Devconsole plugin show essential features like add page and topology also when Builds and DeploymentConfigs capabilities are disabled #13097

merged 1 commit into from Aug 23, 2023

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Aug 21, 2023 •
edited

Fixes:
https://issues.redhat.com/browse/OCPBUGS-17948

Analysis / Root cause:
When Samples, Builds and DeploymentConfigs are disabled, the OPENSHIFT flag stays disabled.

Solution Description:
Use different smaller feature flags for different resources instead of using one big flag for everything.

This is similar to #13089, I aligned the flag names to that PR, but both PRs could be merged separately!

  1. Added new flags for the related CRDs:
    • OPENSHIFT_BUILDCONFIG
    • OPENSHIFT_DEPLOYMENTCONFIG
    • OPENSHIFT_IMAGESTREAM
    • OPENSHIFT_TEMPLATE
  2. Removed OPENSHIFT dependency for pages that don't require that feature flag, esp. the add page (with the cards), the extendable topology, search, and project page.
  3. Update FLAG.OPENSHIFT to check the API group config.openshift.io instead of apps.openshift.io.

Screen shots / Gifs for design review:
Before:

image

With this PR:

image

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 21, 2023
@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-17948, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-17948

Analysis / Root cause:
todo

Solution Description:
todo

Screen shots / Gifs for design review:
Before:

image

With this PR:

image

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 21, 2023
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2023
@jerolimov
Copy link
Member Author

/cc @jhadvig @invincibleJai @Lucifergene

@jerolimov
Copy link
Member Author

/uncc abhinandan13jan karthikjeeyar

@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-17948, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-17948

Analysis / Root cause:
When Samples, Builds and DeploymentConfigs are disabled, the OPENSHIFT flag stays disabled.

Solution Description:
Use different smaller feature flags for different resources instead of using one big flag for everything.

  1. Added new flags OPENSHIFT_BUILDCONFIGS, DEPLOYMENTCONFIGS, OPENSHIFT_IMAGESTREAMS, and OPENSHIFT_TEMPLATES.
  2. Removed OPENSHIFT dependency for pages that don't require that feature flag, esp. the add page (with the cards), the extendable topology, search, and project page.

Screen shots / Gifs for design review:
Before:

image

With this PR:

image

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-17948, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-17948

Analysis / Root cause:
When Samples, Builds and DeploymentConfigs are disabled, the OPENSHIFT flag stays disabled.

Solution Description:
Use different smaller feature flags for different resources instead of using one big flag for everything.

This is similar to #13089, I aligned the flag names to that PR, but both PRs could be merged separately!

  1. Added new flags OPENSHIFT_BUILDCONFIGS, DEPLOYMENTCONFIGS, OPENSHIFT_IMAGESTREAMS, and OPENSHIFT_TEMPLATES.
  2. Removed OPENSHIFT dependency for pages that don't require that feature flag, esp. the add page (with the cards), the extendable topology, search, and project page.

Screen shots / Gifs for design review:
Before:

image

With this PR:

image

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

/retest

1 similar comment
@jerolimov
Copy link
Member Author

/retest

@Lucifergene
Copy link
Contributor

Looks good to me :)

@Lucifergene
Copy link
Contributor

/retest

1 similar comment
@jerolimov
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Aug 23, 2023
@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-17948, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-17948

Analysis / Root cause:
When Samples, Builds and DeploymentConfigs are disabled, the OPENSHIFT flag stays disabled.

Solution Description:
Use different smaller feature flags for different resources instead of using one big flag for everything.

This is similar to #13089, I aligned the flag names to that PR, but both PRs could be merged separately!

  1. Added new flags OPENSHIFT_BUILDCONFIG, OPENSHIFT_DEPLOYMENTCONFIG, OPENSHIFT_IMAGESTREAM, and OPENSHIFT_TEMPLATE.
  2. Removed OPENSHIFT dependency for pages that don't require that feature flag, esp. the add page (with the cards), the extendable topology, search, and project page.
  3. Update FLAG.OPENSHIFT to check the API group config.openshift.io instead of apps.openshift.io.

Screen shots / Gifs for design review:
Before:

image

With this PR:

image

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-17948, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-17948

Analysis / Root cause:
When Samples, Builds and DeploymentConfigs are disabled, the OPENSHIFT flag stays disabled.

Solution Description:
Use different smaller feature flags for different resources instead of using one big flag for everything.

This is similar to #13089, I aligned the flag names to that PR, but both PRs could be merged separately!

  1. Added new flags for the related CRDs:
  • OPENSHIFT_BUILDCONFIG,
  • OPENSHIFT_DEPLOYMENTCONFIG,
  • OPENSHIFT_IMAGESTREAM, and
  • OPENSHIFT_TEMPLATE.
  1. Removed OPENSHIFT dependency for pages that don't require that feature flag, esp. the add page (with the cards), the extendable topology, search, and project page.
  2. Update FLAG.OPENSHIFT to check the API group config.openshift.io instead of apps.openshift.io.

Screen shots / Gifs for design review:
Before:

image

With this PR:

image

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-17948, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-17948

Analysis / Root cause:
When Samples, Builds and DeploymentConfigs are disabled, the OPENSHIFT flag stays disabled.

Solution Description:
Use different smaller feature flags for different resources instead of using one big flag for everything.

This is similar to #13089, I aligned the flag names to that PR, but both PRs could be merged separately!

  1. Added new flags for the related CRDs:
  • OPENSHIFT_BUILDCONFIG
  • OPENSHIFT_DEPLOYMENTCONFIG
  • OPENSHIFT_IMAGESTREAM
  • OPENSHIFT_TEMPLATE
  1. Removed OPENSHIFT dependency for pages that don't require that feature flag, esp. the add page (with the cards), the extendable topology, search, and project page.
  2. Update FLAG.OPENSHIFT to check the API group config.openshift.io instead of apps.openshift.io.

Screen shots / Gifs for design review:
Before:

image

With this PR:

image

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerolimov
jerolimov commented Aug 23, 2023
View reviewed changes
frontend/public/actions/features.ts
Comment on lines -167 to +168
const openshiftPath = '/apis/apps.openshift.io/v1';
// This config API contains the OpenShift Project, and other mandatory resources
const openshiftPath = '/apis/config.openshift.io/v1';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: The old API group only contains the DeploymentConfig resource which isn't a good candidate to test if its a OpenShift cluster since it's optional starting with 4.14.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jhadvig
jhadvig approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 310e77c into openshift:master Aug 23, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@jerolimov: Jira Issue OCPBUGS-17948: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17948 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-17948

Analysis / Root cause:
When Samples, Builds and DeploymentConfigs are disabled, the OPENSHIFT flag stays disabled.

Solution Description:
Use different smaller feature flags for different resources instead of using one big flag for everything.

This is similar to #13089, I aligned the flag names to that PR, but both PRs could be merged separately!

  1. Added new flags for the related CRDs:
  • OPENSHIFT_BUILDCONFIG
  • OPENSHIFT_DEPLOYMENTCONFIG
  • OPENSHIFT_IMAGESTREAM
  • OPENSHIFT_TEMPLATE
  1. Removed OPENSHIFT dependency for pages that don't require that feature flag, esp. the add page (with the cards), the extendable topology, search, and project page.
  2. Update FLAG.OPENSHIFT to check the API group config.openshift.io instead of apps.openshift.io.

Screen shots / Gifs for design review:
Before:

image

With this PR:

image

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov jerolimov deleted the OCPBUGS-17948 branch August 31, 2023 13:39
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-09-11-201102

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-09-12-024050

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-09-15-101929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@Lucifergene Lucifergene Awaiting requested review from Lucifergene

Assignees

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jerolimov @openshift-ci-robot @Lucifergene @openshift-merge-robot @jhadvig