OCPBUGS-19311: Unhide the Import From Git Tab on the Add page if Pipelines Operator is installed and BuildConfig is not installed in the cluster

[Lucifergene]

Fixes:
https://issues.redhat.com/browse/ODC-7379

Solution Description:
Allowed the Import from Git form to show up even if BuildConfig is not installed in the cluster but Pipelines Operator is installed.

Screen shots / Gifs for design review:

Tab-+Add.OKD.9.mp4

Test setup:

1. Create a cluster without BC
2. Verify the Import from Git does not show up in the Add Page
3. Now, install the Pipelines Operator
4. Verify that it now shows up in the Add page.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@Lucifergene: This pull request references ODC-7379 which is a valid jira issue.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7379

Solution Description:
Allowed the Import from Git form to show up even if BuildConfig is not installed in the cluster but Pipelines Operator is installed.

Screen shots / Gifs for design review:

Tab-+Add.OKD.9.mp4

Test setup:

1. Create a cluster without BC
2. Verify the Import from Git does not show up in the Add Page
3. Now, install the Pipelines Operator
4. Verify that it now shows up in the Add page.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Lucifergene]

/cc @lokanandaprabhu @jerolimov
/uncc @debsmita1 @rohitkrai03

[openshift-ci]

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@Lucifergene: "Dad, I'm hungry." Hello, Hungry. I'm Dad.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

I tested this on a cluster bot and disabled the BuildConfig as described here.

BuildConfig	Pipelines	Expected	Actual	OK / NOK
No	No	No Import from Git	Import from Git option isn't shown, /import/ns/christoph shows 404: Page Not Found	👍
Yes	No	Import from Git without Add Pipelines option	Import from Git option is shown and works as expected	👍
No	Yes	Import from Git that enforce Pipeline usage	Import from Git option is shown, the import with Deployment fail with a short "Not found" message. With "Add pipeline" option checked the import works fine	👍 that pipeline isn't enforced will be handled as part of ODC-7386 / PR #13145
Yes	Yes	Import from Git with Add Pipelines option	Import from Git with Add Pipelines option	👍

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerolimov]

/label px-approved
/label docs-approved

[jerolimov]

/retitle OCPBUGS-19311 Unhide the Import From Git Tab on the Add page if Pipelines Operator is installed and BuildConfig is not installed in the cluster
/label acknowledge-critical-fixes-only

[openshift-ci-robot]

@Lucifergene: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7379

Solution Description:
Allowed the Import from Git form to show up even if BuildConfig is not installed in the cluster but Pipelines Operator is installed.

Screen shots / Gifs for design review:

Tab-+Add.OKD.9.mp4

Test setup:

1. Create a cluster without BC
2. Verify the Import from Git does not show up in the Add Page
3. Now, install the Pipelines Operator
4. Verify that it now shows up in the Add page.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@jerolimov: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/jira refresh

[openshift-ci-robot]

@jerolimov: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/retitle OCPBUGS-19311: Unhide the Import From Git Tab on the Add page if Pipelines Operator is installed and BuildConfig is not installed in the cluster

[openshift-ci-robot]

@Lucifergene: This pull request references Jira Issue OCPBUGS-19311, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7379

Solution Description:
Allowed the Import from Git form to show up even if BuildConfig is not installed in the cluster but Pipelines Operator is installed.

Screen shots / Gifs for design review:

Tab-+Add.OKD.9.mp4

Test setup:

1. Create a cluster without BC
2. Verify the Import from Git does not show up in the Add Page
3. Now, install the Pipelines Operator
4. Verify that it now shows up in the Add page.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/jira refresh

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-19311, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@Lucifergene: Jira Issue OCPBUGS-19311: All pull requests linked via external trackers have merged:

• openshift/console#13128

Jira Issue OCPBUGS-19311 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7379

Solution Description:
Allowed the Import from Git form to show up even if BuildConfig is not installed in the cluster but Pipelines Operator is installed.

Screen shots / Gifs for design review:

Tab-+Add.OKD.9.mp4

Test setup:

1. Create a cluster without BC
2. Verify the Import from Git does not show up in the Add Page
3. Now, install the Pipelines Operator
4. Verify that it now shows up in the Add page.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@jerolimov: new pull request created: #13160

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.